update pre-commit hooks and development tooling docs#11618
Open
xtqqczze wants to merge 2 commits intouutils:mainfrom
Open
update pre-commit hooks and development tooling docs#11618xtqqczze wants to merge 2 commits intouutils:mainfrom
xtqqczze wants to merge 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
sorry but i do value the clippy run |
Contributor
|
We can skip this if --print host-tuple contains macos instead of removing. |
Contributor
Author
|
I will try to progress #11016 in order fix clippy for macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-clippypre-commit hook as it is not fast enough to be usable and fails on macOS.Justification
In my opinion, it's far more likely for a contributor to forget to update the fuzz lockfile than run clippy. There is more value if the hooks run fast and cover easily overlooked issues.