Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui Improvements #225

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pateltanmayp
Copy link

@pateltanmayp pateltanmayp commented Aug 20, 2024

A set of small improvements to the GUI:

  1. The path is now displayed with its actual width (referenced to the underlying map, not the screen). It adjusts dynamically as you zoom such that the path annotation remains true to the map for all zoom levels.
  2. The path width is now shown as a translucent band, with a black centre-line along the actual path.
  3. A toggle now allows you to select the whole path at once without needing manual selection.
  4. If the /novatel/fix topic is present (the topic is configurable), the path is automatically initialized at the location of the first GPS coordinate. The initial heading is approximated using the first few GPS points but this is not fool-proof. Manual rotation may still be required (improvements to follow in a future PR).
  5. When the selector is used for annotating or merging, it is now set to point 0 of the path, instead of the point along the path closest to the centre of the map.

pateltanmayp added 2 commits August 17, 2024 20:26
…e; automatically place path based on /novatel/fix topic
…ait for certain distance threshold between GPS points
@SvenLilge SvenLilge marked this pull request as ready for review August 27, 2024 22:01
@SvenLilge SvenLilge self-requested a review August 27, 2024 22:02
Copy link
Contributor

@a-krawciw a-krawciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't yet had the chance to run the code myself. A few minor improvements but overalll looks really good.

Copy link
Contributor

@a-krawciw a-krawciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments

  • The Annotate Route button has no effect once this mode is selected
  • There is a bit of a horizontal gap to the Annotate Route button

Some warnings you can clean up if you are feeling extra thorough!
image

@pateltanmayp
Copy link
Author

pateltanmayp commented Sep 26, 2024

A couple of minor comments

* The Annotate Route button has no effect once this mode is selected

* There is a bit of a horizontal gap to the Annotate Route button

Some warnings you can clean up if you are feeling extra thorough! image

All should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants