Skip to content

fix: Remove Skia Wasm WebView border #20605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

fix: Remove Skia Wasm WebView border #20605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c18ee3
fix: Remove Skia Wasm WebView border
morning4coffe-dev May 27, 2025
eb6944b
chore: Mark test as manual with description
morning4coffe-dev May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...SamplesApp/UITests.Shared/Microsoft_UI_Xaml_Controls/WebView2Tests/WebView2_Basic.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace UITests.Microsoft_UI_Xaml_Controls.WebView2Tests
/// <summary>
/// An empty page that can be used on its own or navigated to within a Frame.
/// </summary>
[Uno.UI.Samples.Controls.Sample("WebView")]
[Uno.UI.Samples.Controls.Sample("WebView", IsManualTest = true, Description = "The WebView2 should be borderless and the Uno Platform website should be displayed.")]
public sealed partial class WebView2_Basic : Page
{
public WebView2_Basic()
Expand Down
6 changes: 3 additions & 3 deletions src/Uno.UI/UI/Xaml/Controls/WebView/Native/Wasm/NativeWebView.Interop.wasm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ internal static partial class NativeMethods
[JSImport("globalThis.Microsoft.UI.Xaml.Controls.WebView.buildImports")]
internal static partial void BuildImports(string assembly);

[JSImport("globalThis.Microsoft.UI.Xaml.Controls.WebView.initializeStyling")]
internal static partial void InitializeStyling(ElementId htmlId);

[JSImport("globalThis.Microsoft.UI.Xaml.Controls.WebView.reload")]
internal static partial void Reload(ElementId htmlId);

Expand All @@ -44,9 +47,6 @@ internal static partial class NativeMethods
[JSImport("globalThis.Microsoft.UI.Xaml.Controls.WebView.setAttribute")]
internal static partial void SetAttribute(ElementId htmlId, string attribute, string value);

[JSImport("globalThis.Microsoft.UI.Xaml.Controls.WebView.setBackground")]
internal static partial void SetBackground(ElementId htmlId, string value);

[JSImport("globalThis.Microsoft.UI.Xaml.Controls.WebView.setupEvents")]
internal static partial void SetupEvents(ElementId htmlId);

Expand Down
2 changes: 1 addition & 1 deletion src/Uno.UI/UI/Xaml/Controls/WebView/Native/Wasm/NativeWebView.wasm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public NativeWebView(CoreWebView2 coreWebView, ElementId elementId)
_coreWebView = coreWebView;
_elementId = elementId;

NativeMethods.SetBackground(elementId, "transparent");
NativeMethods.InitializeStyling(elementId);
NativeMethods.SetupEvents(elementId);
}

Expand Down
6 changes: 4 additions & 2 deletions src/Uno.UI/ts/Windows/UI/Xaml/Controls/WebView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@ namespace Microsoft.UI.Xaml.Controls {
return (<HTMLIFrameElement>document.getElementById(htmlId)).getAttribute(name);
}

static setBackground(htmlId: string, color: string) {
(<HTMLIFrameElement>document.getElementById(htmlId)).style.backgroundColor = color;
static initializeStyling(htmlId: string) {
const iframe = document.getElementById(htmlId) as HTMLIFrameElement;
iframe.style.backgroundColor = "transparent";
iframe.style.border = "0";
}

static setupEvents(htmlId: string) {
Expand Down
Loading