fix: Remove Skia Wasm WebView border #20605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/wasm 🌐
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the WebView border issue on Skia Wasm by refactoring the styling initialization for the WebView component. The changes include replacing the old SetBackground method with a new InitializeStyling method in both TypeScript and C# code, and updating the NativeMethods interop accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Uno.UI/ts/Windows/UI/Xaml/Controls/WebView.ts | Replaced setBackground with initializeStyling to set transparent background and remove border |
| src/Uno.UI/UI/Xaml/Controls/WebView/Native/Wasm/NativeWebView.wasm.cs | Updated to use InitializeStyling instead of SetBackground |
| src/Uno.UI/UI/Xaml/Controls/WebView/Native/Wasm/NativeWebView.Interop.wasm.cs | Added import for InitializeStyling and removed import for the old SetBackground |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20605/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20605/docs/index.html |
|
|
jeromelaban
reviewed
May 28, 2025
github-actions
bot
added
the
area/automation
MartinZikmund
approved these changes
May 29, 2025
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20605/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20605/docs/index.html |
|
|
morning4coffe-dev
force-pushed
the
dev/doti/remove-skia-wasm-border
branch
from
4ac5503 to
eb6944b
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20605/docs/index.html |
|
|
|
The build 167350 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #20403, closes #20587
PR Type
What kind of change does this PR introduce?
What is the new behavior?
This pull request refactors the styling initialization for the
WebViewcomponent in the Uno Platform. The most significant changes include replacing theSetBackgroundmethod with a newInitializeStylingmethod to streamline and centralize styling setup, and updating related TypeScript and C# code to reflect this change.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.