-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Match TextBox.VerticalContentAlignment with Windows #13810
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There is a problem on Skia where the native Gtk.Entry (shown only on focus), has the text centered vertically, and Gtk.Entry provides no way to change this behavior. So:
So while this PR gets closer to Windows behavior on Skia, I think it could be considered worse because of the inconsistency between focused and unfocused states. |
I guess @ramezgerges work will probably help unblock this. Let's see :) |
@Youssef1313 I think the new behavior is acceptable - it will work properly with rendered |
@MartinZikmund Yup it should work well with the new TextBox implementation, but not the old one which is still the "default": uno/src/Uno.UI/FeatureConfiguration.cs Line 505 in efa47a5
|
@Youssef1313 but that is the default only for now and will "change" soon, and WPF works fine so I don't see this as a big issue |
@Youssef1313 I think this can be revived now after 5.2 |
Yup. Sorry forgot about it earlier |
3bdf399
to
826c6e9
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13810/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13810/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13810/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13810/index.html |
062deb0
to
5190bec
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13810/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13810/index.html |
Ready to be merged! |
GitHub Issue (If applicable): closes #4502, closes #14705.
This is a revert of #4180
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 5dd22d4
This pull request fixes a layout bug in
TextBox
controls and adds a unit test to verify the fix. It also improves the XAML loading logic by using .NET 7.0 source generators and a helper methodLoadXaml
.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):