[Skia.Gtk] TextBox().Text() font size changes on focus/blur
#15032
Assignees
Labels
area/skia/text ✏️
area/skia ✏️
Categorizes an issue or PR as relevant to Skia
difficulty/medium 🤔
Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI
kind/bug
Something isn't working
project/text 🔤
Categorizes an issue or PR as relevant to text (TextBox, PasswordBox, TextBlock, Fonts, …)
Comments
qhj
added
difficulty/tbd
qhj
changed the title
TextBox().PlaceholderText() and blurred TextBox().Text() without setting proper TextBox().FontFamily() render CJK fonts as tofu. TextBox().Text() text size changes on focus/blurTextBox().Text() without setting proper TextBox().FontFamily() and TextBox().PlaceholderText() render CJK fonts as tofu. TextBox().Text() text size changes on focus/blur
qhj
changed the title
TextBox().Text() without setting proper TextBox().FontFamily() and TextBox().PlaceholderText() render CJK fonts as tofu. TextBox().Text() text size changes on focus/blurTextBox().PlaceholderText() and blurred TextBox().Text() without setting proper TextBox().FontFamily() render CJK fonts as tofu. TextBox().Text() text size changes on focus/blur
qhj
changed the title
TextBox().PlaceholderText() and blurred TextBox().Text() without setting proper TextBox().FontFamily() render CJK fonts as tofu. TextBox().Text() text size changes on focus/blurTextBox().PlaceholderText() and blurred TextBox().Text() without setting proper TextBox().FontFamily() render CJK fonts as tofu. (2) TextBox().Text() text size changes on focus/blur
qhj
changed the title
TextBox().PlaceholderText() and blurred TextBox().Text() without setting proper TextBox().FontFamily() render CJK fonts as tofu. (2) TextBox().Text() text size changes on focus/blurTextBox().PlaceholderText() and blurred TextBox().Text() without setting proper TextBox().FontFamily() render CJK fonts as tofu. (2) TextBox().Text() font size changes on focus/blur
Youssef1313
added
area/skia ✏️
|
@Youssef1313 Thanks for your work! I updated project dependencies, confirm that font fallback support works on prerelease version of uno. But I cannot test the second problem, 2024-01-12.20-03-11.mp4While updating dependencies by issuing I don't know if only some of dependencies are updated to prerelease version or if there are bugs in the prereleased packages. Package Manager Console logVisual Studio Debug Console log |
|
@qhj Could you upload the project? It will help investigating this crash. |
|
|
That crash is due to mismatching version that happened when NuGet crashed and failed to update all dependencies. This PR fixes that: qhj/UnoApp1#1 |
|
@Youssef1313 Thank you very much! The problem that |
MartinZikmund
added
difficulty/medium 🤔
qhj
changed the title
TextBox().PlaceholderText() and blurred TextBox().Text() without setting proper TextBox().FontFamily() render CJK fonts as tofu. (2) TextBox().Text() font size changes on focus/blurTextBox().Text() font size changes on focus/blur
|
@qhj does it repro if you use the fluent theme instead? |
|
@jeromelaban Yes. screen record 12024-01-15.23-11-19.mp4Found a new problem that placeholder text and input text are not vertically centered on WinUI (fluent theme). As shown below. screen record 22024-01-15.23-13-28.mp4Created a new repo, https://github.com/qhj/unoApp2 |
|
@qhj Thanks for the update. It's best to attach a zip of the sample, as the repository is not public at this time, but you may also remove it in the future. Thanks! |
|
@jeromelaban Sorry, I forgot to make the repo pubilic, it's public now. And here is the zip file of this repo. |
6 tasks
|
The problem with vertical alignment is tracked in #14705 and should be fixed with #13810. As for the size changing: For a regular TextBox, it seems to be working fine and the size isn't changing, but there are differences in FontWeight between focused and unfocused states. It's mostly a limitation with SkiaSharp and/or Gtk and is being partially tracked in #13725. As for PasswordBox, the size change turned out not be a size change, but a glyph change. We were mistakenly using • in the unfocused passwordbox, and ● in the focused passwordbox (provided by GTK) instead of ● in both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behavior
2024-01-12.23-13-32.mp4
Expected behavior
2024-01-12.23-15-09.mp4
How to reproduce it (as minimally and precisely as possible)
clone https://github.com/qhj/UnoApp1 and run the Skia.Gtk head project
Workaround
No response
Works on UWP/WinUI
Yes
Environment
Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
NuGet package version(s)
No response
Affected platforms
Skia (GTK on Linux/macOS/Windows)
IDE
Visual Studio 2022
IDE version
17.8.4
Relevant plugins
No response
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: