Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Align EasingFunctionBase with WinUI #12214

Merged
merged 6 commits into from
May 15, 2023
Merged

fix!: Align EasingFunctionBase with WinUI #12214

merged 6 commits into from
May 15, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 9, 2023 •
edited
Loading

BREAKING CHANGE: EasingFunctionBase API is now aligned with WinUI

GitHub Issue (If applicable): Part of #8339, closes #11662, closes #12213

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Youssef1313 Youssef1313 mentioned this pull request May 9, 2023
Open
@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform area/build Categorizes an issue or PR as relevant to build infrastructure area/automation Categorizes an issue or PR as relevant to project automation labels May 10, 2023
dr1rrb
dr1rrb reviewed May 10, 2023
View reviewed changes
Copy link
Member

@dr1rrb dr1rrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great! I wanted to do that since so long!

Currently we have tests only for the BounceEase, could please add more so we would be more confident about regression / document breaking changes?

src/Uno.UI/UI/Xaml/Media/Animation/EasingFunctionBase.cs Outdated Show resolved Hide resolved
@Youssef1313 Youssef1313 requested review from jeromelaban and dr1rrb May 11, 2023 14:05
@Youssef1313
Copy link
Member Author

@dr1rrb @jeromelaban Is this ready to merge?

@Youssef1313 Youssef1313 mentioned this pull request May 11, 2023
Closed
6 tasks
@jeromelaban jeromelaban merged commit 34c8d64 into unoplatform:feature/breaking-changes May 15, 2023
@Youssef1313 Youssef1313 deleted the align-easing branch May 15, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @jeromelaban @dr1rrb