Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Misc breaking changes #12261

Closed
wants to merge 15 commits into from
Closed

fix!: Misc breaking changes #12261

wants to merge 15 commits into from

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 force-pushed the more-misc-breaking-changes branch from 1adad31 to 8495247 Compare May 11, 2023 15:44
@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform labels May 11, 2023
@Youssef1313 Youssef1313 force-pushed the more-misc-breaking-changes branch 2 times, most recently from 76786bb to cf00de2 Compare May 11, 2023 20:43
@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform labels May 11, 2023
@Youssef1313 Youssef1313 force-pushed the more-misc-breaking-changes branch 2 times, most recently from 6b89bd8 to b922b4b Compare May 11, 2023 20:50
@Youssef1313
Copy link
Member Author

For this to get green, both #12214 and #12248 are needed. Keeping as draft for now and cancelled the build.

@Youssef1313 Youssef1313 mentioned this pull request May 11, 2023
Open
@Youssef1313 Youssef1313 force-pushed the more-misc-breaking-changes branch from b922b4b to b88907c Compare May 12, 2023 06:51
@Youssef1313 Youssef1313 mentioned this pull request May 12, 2023
Closed
6 tasks
@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Youssef1313 Youssef1313 force-pushed the more-misc-breaking-changes branch 2 times, most recently from 1bb048c to b88907c Compare May 23, 2023 19:58
@Youssef1313 Youssef1313 force-pushed the more-misc-breaking-changes branch from b88907c to 527f03f Compare May 23, 2023 20:01
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label May 29, 2023
@Youssef1313 Youssef1313 marked this pull request as ready for review May 30, 2023 15:21
@Youssef1313 Youssef1313 requested a review from jeromelaban May 30, 2023 15:22
@jeromelaban jeromelaban deleted the branch unoplatform:feature/breaking-changes June 9, 2023 17:39
@jeromelaban jeromelaban closed this Jun 9, 2023
@Youssef1313 Youssef1313 mentioned this pull request Jun 9, 2023
Merged
6 tasks
@Youssef1313 Youssef1313 deleted the more-misc-breaking-changes branch June 11, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youssef1313 @jeromelaban