Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove ResourcesService and ResourceHelper #12197

Conversation

Youssef1313
Copy link
Member

BREAKING CHANGE: Remove ResourcesService and ResourceHelper

GitHub Issue (If applicable): Part of #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/build Categorizes an issue or PR as relevant to build infrastructure platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform labels May 8, 2023
@Youssef1313 Youssef1313 force-pushed the remove-resourcehelper-resourcesservice branch from 71e5998 to 2d9cdc7 Compare May 8, 2023 12:20
@Youssef1313 Youssef1313 force-pushed the remove-resourcehelper-resourcesservice branch 3 times, most recently from dc28a16 to 2f9c1ff Compare May 10, 2023 18:27
BREAKING CHANGE: Remove `ResourcesService` and `ResourceHelper`
@Youssef1313 Youssef1313 force-pushed the remove-resourcehelper-resourcesservice branch from 2f9c1ff to 3332153 Compare May 12, 2023 14:02
@Youssef1313 Youssef1313 merged commit 16f010a into unoplatform:feature/breaking-changes May 13, 2023
@Youssef1313 Youssef1313 deleted the remove-resourcehelper-resourcesservice branch May 13, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants