Skip to content

Commit

Permalink
fix!: Remove ResourcesService and ResourceHelper
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Remove `ResourcesService` and `ResourceHelper`
  • Loading branch information
Youssef1313 committed May 8, 2023
1 parent ade59d3 commit 71e5998
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 142 deletions.
4 changes: 2 additions & 2 deletions build/PackageDiffIgnore.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9163,12 +9163,12 @@

<Member fullName="Uno.UI.IndexPath" reason="Api alignments" />
<Member fullName="Uno.UI.IResourcesService" reason="Api alignments" />
<Member fullName="Uno.UI.Services.ResourcesService" reason="Api alignments" />
<Member fullName="Uno.UI.Common.DelegateCommand" reason="Api alignments" />
<Member fullName="Uno.UI.Common.DelegateCommand`1" reason="Api alignments" />
<Member fullName="Windows.Foundation.SizeConverter" reason="Api alignments" />
<Member fullName="Windows.UI.Xaml.ResourceHelper" reason="Api alignments" />
<Member fullName="Uno.UI.Extensions.CollectionViewExtensions" reason="Api alignments" />

</Types>
<Events>
<Member fullName="Windows.Foundation.TypedEventHandler`2&lt;Microsoft.UI.Xaml.Controls.IInputValidationControl,Microsoft.UI.Xaml.Controls.HasValidationErrorsChangedEventArgs&gt; Microsoft.UI.Xaml.Controls.AutoSuggestBox::HasValidationErrorsChanged" reason="Not present in WinAppSDK 1.2" />
Expand Down Expand Up @@ -9599,7 +9599,7 @@
<Member fullName="Windows.UI.Xaml.Controls.VirtualizingPanelLayout/Line Windows.UI.Xaml.Controls.VirtualizingPanelLayout.CreateLine(Windows.UI.Xaml.Controls.Primitives.GeneratorDirection fillDirection, System.Int32 extentOffset, System.Int32 breadthOffset, System.Int32 availableBreadth, AndroidX.RecyclerView.Widget.RecyclerView/Recycler recycler, AndroidX.RecyclerView.Widget.RecyclerView/State state, Uno.UI.IndexPath nextVisibleItem, System.Boolean isNewGroup)" reason="Api alignments" />
<Member fullName="System.Nullable`1&lt;Uno.UI.IndexPath&gt; Windows.UI.Xaml.Controls.VirtualizingPanelLayout.GetDynamicSeedIndex(System.Nullable`1&lt;Uno.UI.IndexPath&gt; firstVisibleItem, System.Int32 availableBreadth)" reason="Api alignments" />
<Member fullName="System.String Uno.UI.Services.ResourcesService.Get(System.String id)" reason="Api alignments" />

<Member fullName="System.Void Windows.UI.Xaml.Window.set_Visible(System.Boolean value)" reason="Does not exist in UWP and WinUI" />
</Methods>
</IgnoreSet>
Expand Down

This file was deleted.

51 changes: 0 additions & 51 deletions src/Uno.UI/Services/ResourceService.iOSmacOS.cs

This file was deleted.

28 changes: 0 additions & 28 deletions src/Uno.UI/Services/ResourcesService.Android.cs

This file was deleted.

1 change: 0 additions & 1 deletion src/Uno.UI/UI/Xaml/Application.iOS.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public Application()
{
Current = this;
SetCurrentLanguage();
ResourceHelper.ResourcesService = new ResourcesService(new[] { NSBundle.MainBundle });

SubscribeBackgroundNotifications();
}
Expand Down
30 changes: 0 additions & 30 deletions src/Uno.UI/UI/Xaml/ResourceHelper.cs

This file was deleted.

0 comments on commit 71e5998

Please sign in to comment.