Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import oa-renderer to project-vckit #75

Merged
merged 11 commits into from
Jun 13, 2023

Conversation

toannvit
Copy link
Contributor

@toannvit toannvit commented May 23, 2023

Linked Issue

Changes

  • add oa-renderer to project-vckit
  • update readme to reflect new build tooling
  • update package.json to align package naming and version
  • implement svg template
  • setup the purchaseOrderSample sample
  • add unit test and integration test
  • write storybook

Screenshot

image image

Toan Ngo and others added 2 commits May 18, 2023 14:43
(cherry picked from commit e38db5ff026a1c3360869997ce00a1531a53542d)
(cherry picked from commit e4baf53c7f225cfd83650c1328b860d47f2cff20)
Copy link
Contributor

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arpentnoir arpentnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some version bumps have snuck in to the lockfile that do not relate to the import of the template repo package. I should have been more explicit about running pnpm install --frozen-lockfile in fresh repo clone before importing the renderer template package. don't want lockfile to change unless done explicitly...

lerna.json Outdated Show resolved Hide resolved
packages/vckit-oa-renderers/package.json Show resolved Hide resolved
packages/vckit-oa-renderers/package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@arpentnoir
Copy link
Contributor

vckit-oa-renderers/package-lock.json should have been removed with the commit that changes build tooling for renderer template package from npm to pnpm.

Copy link
Contributor

@arpentnoir arpentnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the purpose of the docs: commit, as described in the ticket, was to change the renderer template readme (not the root level readme) to reflect that it should now be installed, run, etc with pnpm instead of npm

@arpentnoir
Copy link
Contributor

gs-gs#17 should be part of this PR

Signed-off-by: Nam Hoang <[email protected]>
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit d43c62c)
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit a6305ca)
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit 46fc9b9)
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit 768db5a)
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit 613d5ef)
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit 7f8acda)
@namhoang1604 namhoang1604 force-pushed the feat/import-oa-renderer-to-vckit branch from 7f8acda to 76cd09b Compare June 9, 2023 04:19
@namhoang1604 namhoang1604 reopened this Jun 12, 2023
@arpentnoir arpentnoir merged commit 394f654 into uncefact:main Jun 13, 2023
@namhoang1604 namhoang1604 deleted the feat/import-oa-renderer-to-vckit branch June 26, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants