-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import oa-renderer to project-vckit #75
feat: import oa-renderer to project-vckit #75
Conversation
(cherry picked from commit e38db5ff026a1c3360869997ce00a1531a53542d)
(cherry picked from commit e4baf53c7f225cfd83650c1328b860d47f2cff20)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some version bumps have snuck in to the lockfile that do not relate to the import of the template repo package. I should have been more explicit about running pnpm install --frozen-lockfile
in fresh repo clone before importing the renderer template package. don't want lockfile to change unless done explicitly...
vckit-oa-renderers/package-lock.json should have been removed with the commit that changes build tooling for renderer template package from npm to pnpm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the purpose of the docs: commit, as described in the ticket, was to change the renderer template readme (not the root level readme) to reflect that it should now be installed, run, etc with pnpm instead of npm
gs-gs#17 should be part of this PR |
Signed-off-by: Nam Hoang <[email protected]>
Signed-off-by: Nam Hoang <[email protected]>
Signed-off-by: Nam Hoang <[email protected]> (cherry picked from commit d43c62c)
Signed-off-by: Nam Hoang <[email protected]> (cherry picked from commit a6305ca)
Signed-off-by: Nam Hoang <[email protected]> (cherry picked from commit 46fc9b9)
Signed-off-by: Nam Hoang <[email protected]> (cherry picked from commit 768db5a)
Signed-off-by: Nam Hoang <[email protected]> (cherry picked from commit 613d5ef)
Signed-off-by: Nam Hoang <[email protected]> (cherry picked from commit 7f8acda)
7f8acda
to
76cd09b
Compare
Signed-off-by: Nam Hoang <[email protected]>
Linked Issue
Changes
oa-renderer
toproject-vckit
Screenshot