Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create sample parameterised svg #73

Closed
wants to merge 16 commits into from
Closed

feat: create sample parameterised svg #73

wants to merge 16 commits into from

Conversation

namhoang1604
Copy link
Contributor

@namhoang1604 namhoang1604 commented May 23, 2023 •
edited
Loading

Linked Issue

Type of change

  • Implement the parameterized SVG renderer (non-breaking change which adds functionality)
  • This change requires a documentation update (storybook and example apps)
  • This change requires the unit test and e2e test update

Screenshot

image image image

Toan Ngo and others added 11 commits May 18, 2023 14:43
chore: import oa renderer into project-vckit
06ccb9c 
(cherry picked from commit e38db5ff026a1c3360869997ce00a1531a53542d)
build: add new build tooling
cc99403 
(cherry picked from commit e4baf53c7f225cfd83650c1328b860d47f2cff20)
docs: update readme to reflect new build tooling
7ae7b71 
(cherry picked from commit 3863c9123941a3249cc8d2d768bb198627f3c14d)
chore: update package naming and version
b1408c8
@namhoang1604
feat: implement svg template renderer
57ca4a3
@namhoang1604
chore: update test library and add configs to scripts
fa16716
@namhoang1604
test: cover the parameterized SVG renderer
9e6ad6b
@namhoang1604
docs: add a storybook for the parameterized SVG renderer
21618d2
@namhoang1604
test: add e2e testing for the parameterized SVG renderer
b3ededd
@namhoang1604
docs: update example of the application for the SVG renderer
d0197a7
@namhoang1604
docs: rearrange example file folder
9f61819
@namhoang1604 namhoang1604 mentioned this pull request May 23, 2023
Closed
3 tasks
@namhoang1604 namhoang1604 self-assigned this May 23, 2023
@namhoang1604 namhoang1604 force-pushed the feat/create-sample-parameterised-SVG branch from 02fb29c to 8ca327c Compare May 25, 2023 08:32
@namhoang1604 namhoang1604 force-pushed the feat/create-sample-parameterised-SVG branch from 8ca327c to 16ad75a Compare June 7, 2023 09:10
@namhoang1604 namhoang1604 marked this pull request as ready for review June 7, 2023 09:10
@namhoang1604 namhoang1604 changed the title [WIP] feat: create sample parameterised svg feat: create sample parameterised svg Jun 7, 2023
@namhoang1604 namhoang1604 force-pushed the feat/create-sample-parameterised-SVG branch from 9d4d287 to 16ad75a Compare June 7, 2023 09:16
@namhoang1604
Copy link
Contributor Author

Close to moving to this PR #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpentnoir arpentnoir Awaiting requested review from arpentnoir

@toannvit toannvit Awaiting requested review from toannvit

@hoa-ngo-gs hoa-ngo-gs Awaiting requested review from hoa-ngo-gs

Assignees

@namhoang1604 namhoang1604

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@namhoang1604