Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: create sample parameterised svg #19

Closed
wants to merge 11 commits into from

Conversation

namhoang1604
Copy link
Collaborator

Linked Issue

Type of change

  • Implement the parameterized SVG renderer (non-breaking change which adds functionality)
  • This change requires a documentation update (storybook and example apps)
  • This change requires the unit test and e2e test update

Screenshot

image image image

@namhoang1604 namhoang1604 added the enhancement New feature or request label May 21, 2023
@namhoang1604 namhoang1604 self-assigned this May 22, 2023
@namhoang1604 namhoang1604 force-pushed the feat/create-sample-parameterised-SVG branch from 7560515 to 9f61819 Compare May 22, 2023 03:17
`}
>
<FrameConnector
source="http://localhost:3000"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move this to env file or if it's mock , bring it to top of the file

@toannvit
Copy link

LGTM except for one small change

@namhoang1604
Copy link
Collaborator Author

Close the PR to move to uncefact#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants