[WIP] feat: create sample parameterised svg #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e38db5ff026a1c3360869997ce00a1531a53542d)
(cherry picked from commit e4baf53c7f225cfd83650c1328b860d47f2cff20)
(cherry picked from commit 3863c9123941a3249cc8d2d768bb198627f3c14d)
namhoang1604
force-pushed
the
feat/create-sample-parameterised-SVG
branch
from
7560515
to
9f61819
Compare
toannvit
suggested changes
May 22, 2023
| `} | ||
| > | ||
| <FrameConnector | ||
| source="http://localhost:3000" |
There was a problem hiding this comment.
maybe move this to env file or if it's mock , bring it to top of the file
|
LGTM except for one small change |
|
Close the PR to move to uncefact#73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Type of change
Screenshot