-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix frequent LookupError exceptions #282
base: master
Are you sure you want to change the base?
Changes from 3 commits
4e6a563
2bdcc82
4a42fda
c15ee7e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,7 +78,5 @@ services: | |
container_name: hmrc-redis | ||
expose: | ||
- 6379 | ||
ports: | ||
- 6379:6379 | ||
volumes: | ||
maildata: |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -338,7 +338,7 @@ def sort_dtos_by_date(input_dtos): | |
|
||
def log_to_sentry(message, extra=None, level="info"): | ||
extra = extra or {} | ||
with sentry_sdk.new_scope() as scope: | ||
with sentry_sdk.push_scope() as scope: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see that this is what we had before (https://github.com/uktrade/lite-hmrc/pull/274/files) so am I right to infer that the main change for this PR that we think will solve the issue is the version downgrade to 1.x ? |
||
for key, value in extra.items(): | ||
scope.set_extra(key, value) | ||
sentry_sdk.capture_message(message, level=level) | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I ask what this change does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually nvm I just read your commit messages which answered my question