Fix frequent LookupError exceptions #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnryjmes
reviewed
Nov 5, 2024
Comment on lines
-81
to
-82
| ports: | ||
| - 6379:6379 |
There was a problem hiding this comment.
can I ask what this change does?
There was a problem hiding this comment.
actually nvm I just read your commit messages which answered my question
hnryjmes
reviewed
Nov 5, 2024
| @@ -338,7 +338,7 @@ def sort_dtos_by_date(input_dtos): | |||
|
|
|||
| def log_to_sentry(message, extra=None, level="info"): | |||
| extra = extra or {} | |||
| with sentry_sdk.new_scope() as scope: | |||
| with sentry_sdk.push_scope() as scope: | |||
There was a problem hiding this comment.
I see that this is what we had before (https://github.com/uktrade/lite-hmrc/pull/274/files) so am I right to infer that the main change for this PR that we think will solve the issue is the version downgrade to 1.x ?
hnryjmes
approved these changes
Nov 5, 2024
kevincarrogan
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to fix the LookupError exceptions which we have been seeing frequently on sentry for production lite-hmrc. Unfortunately, this particular exception is very tricky to reproduce - so it's difficult to know if this will fix it or not. This PR takes a bit of an educated guess that the LookupErrors started when we upgraded sentry-sdk to 2.X; looking at the errors it seems there are issues accessing the
ContextVarcurrent_scopeand it seems from looking at the sentry-sdk codebase that there has been work around this between 1.X and 2.X.We don't have the luxury of time to look too deeply in to this - as it's not a blocking error and just an annoyance.