Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pam/integration-tests): Highlight PAM error messages better #552

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Sep 24, 2024

Ensure they're clearly marked as such so that we don't confuse them with simple info messages.

@3v1n0 3v1n0 requested a review from a team as a code owner September 24, 2024 16:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (faa84f2) to head (0de6d48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   84.76%   84.79%   +0.02%     
==========================================
  Files          79       79              
  Lines        6957     6957              
  Branches       75       75              
==========================================
+ Hits         5897     5899       +2     
+ Misses        741      739       -2     
  Partials      319      319              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, I think, but it's your call if it's better or not. Besides that, looks great!

Ensure they're clearly marked as such so that we don't confuse them with
simple info messages.
@3v1n0 3v1n0 merged commit 41e4039 into ubuntu:main Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants