Skip to content

Commit

Permalink
cleanup(pam/integration-tests): Highlight PAM error messages better (#…
Browse files Browse the repository at this point in the history
…552)

Ensure they're clearly marked as such so that we don't confuse them with
simple info messages.
  • Loading branch information
3v1n0 authored Sep 25, 2024
2 parents faa84f2 + 0de6d48 commit 41e4039
Show file tree
Hide file tree
Showing 15 changed files with 196 additions and 196 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3108,7 +3108,7 @@ Select action: r
7 - Use a QR code
8 - Authentication code
Select authentication mode: invalid-selection
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand Down Expand Up @@ -3265,7 +3265,7 @@ Select action: r
7 - Use a QR code
8 - Authentication code
Select authentication mode: invalid-selection
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand All @@ -3276,7 +3276,7 @@ Provided input can't be parsed as integer value
7 - Use a QR code
8 - Authentication code
Select authentication mode: -1
Invalid entry. Try again or input 'r'.
PAM Error Message: Invalid entry. Try again or input 'r'.
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand Down Expand Up @@ -3422,7 +3422,7 @@ Select action: r
7 - Use a QR code
8 - Authentication code
Select authentication mode: invalid-selection
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand All @@ -3433,7 +3433,7 @@ Provided input can't be parsed as integer value
7 - Use a QR code
8 - Authentication code
Select authentication mode: -1
Invalid entry. Try again or input 'r'.
PAM Error Message: Invalid entry. Try again or input 'r'.
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand Down Expand Up @@ -3579,7 +3579,7 @@ Select action: r
7 - Use a QR code
8 - Authentication code
Select authentication mode: invalid-selection
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand All @@ -3590,7 +3590,7 @@ Provided input can't be parsed as integer value
7 - Use a QR code
8 - Authentication code
Select authentication mode: -1
Invalid entry. Try again or input 'r'.
PAM Error Message: Invalid entry. Try again or input 'r'.
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand Down Expand Up @@ -3736,7 +3736,7 @@ Select action: r
7 - Use a QR code
8 - Authentication code
Select authentication mode: invalid-selection
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand All @@ -3747,7 +3747,7 @@ Provided input can't be parsed as integer value
7 - Use a QR code
8 - Authentication code
Select authentication mode: -1
Invalid entry. Try again or input 'r'.
PAM Error Message: Invalid entry. Try again or input 'r'.
== Authentication mode selection (use 'r' to go back) ==
1 - Password authentication
2 - Send URL to [email protected]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ Select authentication mode: r
1 - local
2 - ExampleBroker
Select broker: invalid-ID
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Broker selection (use 'r' to go back) ==
1 - local
2 - ExampleBroker
Expand Down Expand Up @@ -300,12 +300,12 @@ Select authentication mode: r
1 - local
2 - ExampleBroker
Select broker: invalid-ID
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Broker selection (use 'r' to go back) ==
1 - local
2 - ExampleBroker
Select broker: 555
Invalid entry. Try again or input 'r'.
PAM Error Message: Invalid entry. Try again or input 'r'.
== Broker selection (use 'r' to go back) ==
1 - local
2 - ExampleBroker
Expand Down Expand Up @@ -340,12 +340,12 @@ Select authentication mode: r
1 - local
2 - ExampleBroker
Select broker: invalid-ID
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Broker selection (use 'r' to go back) ==
1 - local
2 - ExampleBroker
Select broker: 555
Invalid entry. Try again or input 'r'.
PAM Error Message: Invalid entry. Try again or input 'r'.
== Broker selection (use 'r' to go back) ==
1 - local
2 - ExampleBroker
Expand Down Expand Up @@ -380,12 +380,12 @@ Select authentication mode: r
1 - local
2 - ExampleBroker
Select broker: invalid-ID
Provided input can't be parsed as integer value
PAM Error Message: Provided input can't be parsed as integer value
== Broker selection (use 'r' to go back) ==
1 - local
2 - ExampleBroker
Select broker: 555
Invalid entry. Try again or input 'r'.
PAM Error Message: Invalid entry. Try again or input 'r'.
== Broker selection (use 'r' to go back) ==
1 - local
2 - ExampleBroker
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):

Expand Down Expand Up @@ -344,10 +344,10 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):

Expand Down Expand Up @@ -377,13 +377,13 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):

Expand All @@ -410,16 +410,16 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is shorter than 8 characters
PAM Error Message: The password is shorter than 8 characters
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):

Expand All @@ -443,16 +443,16 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is shorter than 8 characters
PAM Error Message: The password is shorter than 8 characters
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):

Expand All @@ -476,16 +476,16 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is shorter than 8 characters
PAM Error Message: The password is shorter than 8 characters
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
Repeat the previously inserted password or insert 'r' to cancel the request and go back
Expand All @@ -509,16 +509,16 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is shorter than 8 characters
PAM Error Message: The password is shorter than 8 characters
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
Repeat the previously inserted password or insert 'r' to cancel the request and go back
Expand All @@ -542,16 +542,16 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is shorter than 8 characters
PAM Error Message: The password is shorter than 8 characters
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
Repeat the previously inserted password or insert 'r' to cancel the request and go back
Expand All @@ -575,16 +575,16 @@ Plug your fido device and press with your thumb:
Select action: 1
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password fails the dictionary check - it is based on a dictionary word
PAM Error Message: The password fails the dictionary check - it is based on a dictionary word
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is the same as the old one
PAM Error Message: The password is the same as the old one
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
The password is shorter than 8 characters
PAM Error Message: The password is shorter than 8 characters
Insert 'r' to cancel the request and go back
Enter your new password (3 days until mandatory):
Repeat the previously inserted password or insert 'r' to cancel the request and go back
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ Username:
────────────────────────────────────────────────────────────────────────────────
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK} force_native_client=true
Username:
could not get current available brokers: permission denied: this action is only allowed for root
users. Current user is XXXX
PAM Error Message: could not get current available brokers: permission denied: this action is on
ly allowed for root users. Current user is XXXX
PAM Authenticate() for user "" exited with error (PAM exit code: 4): System error
acct=incomplete
PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
Expand Down Expand Up @@ -66,8 +66,8 @@ dispatch
────────────────────────────────────────────────────────────────────────────────
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK} force_native_client=true
Username:
could not get current available brokers: permission denied: this action is only allowed for root
users. Current user is XXXX
PAM Error Message: could not get current available brokers: permission denied: this action is on
ly allowed for root users. Current user is XXXX
PAM Authenticate() for user "" exited with error (PAM exit code: 4): System error
acct=incomplete
PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
Expand Down
Loading

0 comments on commit 41e4039

Please sign in to comment.