Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UbiquityPool UI Update #860

Closed
wants to merge 11 commits into from
Closed

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Dec 27, 2023

Resolves #833

@molecula451 molecula451 changed the title UbiquityPool UI chore: UbiquityPool UI Update Dec 31, 2023
@molecula451
Copy link
Member

i think the best it's to design a new table from ground up, instead of mocking one similar to frax, what you think? @rndquu

@0x4007
Copy link
Member

0x4007 commented Jan 19, 2024

Honestly I am heavily leaning towards making separate NON REACT separate pages per view. I feel like this would greatly simplify the development, at the risk of slightly non matching elements/behaviors across pages (this technically could be remedied with a shared generic stylesheet though!)

I haven't worked on this repository for a while so I haven't made any initiative towards this, but I remember that dealing with the UI in the past was incredibly unwieldily.

Anyways if you guys are more comfortable to proceed in React for now, then sure; but if I do get a chance to dive into this, there's a high chance I'm going to want to go raw (like in https://github.com/ubiquity/work.ubq.fi/)

@0x4007 0x4007 mentioned this pull request Jan 19, 2024
@rndquu
Copy link
Member Author

rndquu commented Jan 19, 2024

i think the best it's to design a new table from ground up, instead of mocking one similar to frax, what you think? @rndquu

It won't be a frax'es mock but a simple UI enough to mint/redeem Dollars

Honestly I am heavily leaning towards making separate NON REACT separate pages per view.

I like that react is widely used but don't like to choose over 100 hooks for different use cases. It was way simpler in the early days with class components.

Anyways if you guys are more comfortable to proceed in React for now, then sure; but if I do get a chance to dive into this, there's a high chance I'm going to want to go raw (like in https://github.com/ubiquity/work.ubq.fi/)

We'll finish the Ubiquity pool page with the current stack so that we could test minting and redeeming of Dollar tokens. Raw js/css will eventually bring us to a mess. If you guys have experience with some simple frontend framework then suggestions are welcome.

@molecula451
Copy link
Member

molecula451 commented Jan 19, 2024

the thing is our whole frontend is make of React i think the approach you mention is good draw a simple table that shows minting/redeeming and a calculation and move on to further visual aspects, later on

@0x4007
Copy link
Member

0x4007 commented Jan 19, 2024

We might be able to whip up a quick version of the UI by doing a wget -r lol

@rndquu
Copy link
Member Author

rndquu commented Mar 25, 2024

I will open a new PR reflecting changes introduced in the audit

@rndquu rndquu closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dApp: create UI for UbiquityPool
3 participants