Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp: create UI for UbiquityPool #833

Open
Tracked by #835
rndquu opened this issue Nov 15, 2023 · 26 comments · May be fixed by #936
Open
Tracked by #835

dApp: create UI for UbiquityPool #833

rndquu opened this issue Nov 15, 2023 · 26 comments · May be fixed by #936
Assignees

Comments

@rndquu
Copy link
Member

rndquu commented Nov 15, 2023

Depends on #832

There is the new UbiquityPool contract (facet) where users can mint and redeem Dollar tokens for collateral tokens.

Minting example:

  1. User calls mintDollar() and sends 100 LUSD as collateral
  2. User gets 100 Dollar tokens

Redeeming example:

  1. User calls redeemDollar() and sends 100 Dollar tokens
  2. User waits for 2 blocks to be mined
  3. User calls collectRedemption() and gets 100 LUSD collateral back

We should create a new UI page for the UbiquityPool contract and make sure that it works with the local anvil deploy script.

Since the UbiquityPool contract is forked from the FraxPoolV3 contract we can take the Frax UI as an example:

Notice: the getDollarPriceUsd() method may revert (because TWAP is not part of the deployment script, will be fixed in #827) so you will have to mock it

P.S. All protocol contracts used in the UI can be found here

Mint:
Screenshot 2023-11-15 at 16 18 53

Redeem:
Screenshot 2023-11-15 at 16 19 00

@Vayras
Copy link

Vayras commented Nov 27, 2023

Hi, I would like to contribute towards this issue

Copy link

ubiquibot bot commented Nov 27, 2023

Available commands

- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /autopay: Toggle automatic payment for the completion of the current issue.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@Vayras

@rndquu
Copy link
Member Author

rndquu commented Nov 27, 2023

Hi, I would like to contribute towards this issue

Hey, you're free to start with the /start command

@yeshealer
Copy link

/start

Copy link

ubiquibot bot commented Nov 30, 2023

Deadline Fri, 01 Dec 2023 14:45:39 UTC
Registered Wallet Please set your wallet address to use `/wallet 0x0000...0000`
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @yeshealer
    Copy link

    /wallet 0xA09f6409c2BA41845a878c37639931980476b47c

    Copy link

    ubiquibot bot commented Nov 30, 2023

    Updated the wallet address for @yeshealer successfully! Your new address: 0xA09f6409c2BA41845a878c37639931980476b47c

    @yeshealer
    Copy link

    @rndquu I have a question, Should I create UI separately with this project or create new project for this faucet?

    @rndquu
    Copy link
    Member Author

    rndquu commented Nov 30, 2023

    @rndquu I have a question, Should I create UI separately with this project or create new project for this faucet?

    We should add a new web page here https://github.com/ubiquity/ubiquity-dollar/tree/development/packages/dapp

    @yeshealer
    Copy link

    thanks, one more question. Your project running environment is Ubuntu not windows?

    @rndquu
    Copy link
    Member Author

    rndquu commented Nov 30, 2023

    thanks, one more question. Your project running environment is Ubuntu not windows?

    Yes, the project definitely works on macos/linux, not sure about windows though

    @yeshealer
    Copy link

    thanks, one more question. Your project running environment is Ubuntu not windows?

    Yes, the project definitely works on macos/linux, not sure about windows though

    I see thanks

    @molecula451
    Copy link
    Member

    thanks, one more question. Your project running environment is Ubuntu not windows?

    the project basically is a node package + solidity smart contracts, so it's multi-platform, and you should have no issues running on Windows, or any other OS, as the project is not OS dependent, just check your nodejs enviroment

    @rndquu
    Copy link
    Member Author

    rndquu commented Dec 7, 2023

    @yeshealer Hey, how is it going?

    @yeshealer
    Copy link

    doing now. gonna show the result on next monday!!!

    @molecula451
    Copy link
    Member

    not working anymore? @yeshealer

    Copy link

    ubiquibot bot commented Dec 14, 2023

    # Comment event received without a recognized user command.

    Copy link

    ubiquibot bot commented Dec 14, 2023

    @@ No latest assign event found. @@

    @molecula451
    Copy link
    Member

    @rndquu you think theres a forkable version of this UI?

    @rndquu
    Copy link
    Member Author

    rndquu commented Dec 18, 2023

    @rndquu you think theres a forkable version of this UI?

    Perhaps, I haven't checked yet

    @rndquu rndquu self-assigned this Dec 21, 2023
    Copy link

    ubiquibot bot commented Dec 21, 2023

    #  @rndquu the deadline is at 2023-12-22T21:10:03.107Z

    @PhantomCracker
    Copy link
    Contributor

    Hei @rndquu I will take this on my side, is ok ?

    @ubiquibot ubiquibot bot unassigned rndquu Jan 10, 2024
    @rndquu
    Copy link
    Member Author

    rndquu commented Jan 11, 2024

    Hei @rndquu I will take this on my side, is ok ?

    Sorry, I'm already working on it #860

    Copy link

    ubiquibot bot commented Mar 25, 2024

    @rndquu the deadline is at 2024-03-26T06:32:06.294Z

    @PhantomCracker
    Copy link
    Contributor

    Hei @rndquu, if you need help on this, please let me know.

    @ubiquibot ubiquibot bot unassigned rndquu Apr 9, 2024
    @rndquu rndquu self-assigned this Apr 9, 2024
    Copy link

    ubiquibot bot commented Apr 9, 2024

    @rndquu the deadline is at 2024-04-10T15:05:01.694Z

    @rndquu rndquu linked a pull request May 6, 2024 that will close this issue
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    5 participants