feat: add oracle migrations #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitcoindev
approved these changes
Dec 22, 2023
molecula451
reviewed
Dec 22, 2023
packages/contracts/migrations/development/Deploy001_Diamond_Dollar.s.sol
Outdated
Show resolved
Hide resolved
molecula451
reviewed
Dec 22, 2023
packages/contracts/migrations/development/Deploy001_Diamond_Dollar.s.sol
Outdated
Show resolved
Hide resolved
|
Merging this PR because it blocks some of the tasks. @molecula451 If you have any other remarks pls let me know. |
|
I am keeping an eye on this one, moving on for now as I am sure we needed it at the soonest! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates migration scripts to deploy oracle related contracts.
We've got the following oracle related contracts:
Development migration deploys all oracle related contracts from scratch for ease of debugging.
Mainnet migration uses already deployed oracle related contracts.
The only catch is that we haven't yet redeployed the old Dollar-3CRVLP metapool because we need the new
Dollartoken contract to be redeployed hence this commented block.