Skip to content

Add remaining currency symbols, deprecate franc #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add remaining currency symbols, deprecate franc #59

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1989f32
Deprecate franc
Enivex Apr 26, 2025
dd11343
Rupee symbols
Enivex Apr 26, 2025
31d03be
All non-colon currencies
Enivex Apr 26, 2025
b5c1a4a
Add the costa rican colon
Enivex Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/modules/sym.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ backslash \
.not ⧷
co ℅
colon :
.currency ₡
Comment on lines 114 to +115
Copy link
Collaborator

@mkorje mkorje Apr 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This confused me a bit at first and I'm not sure this is a good name for the symbol, but I understand why you've done it.

An idea: maybe we could put all the currency symbols as modifiers under currency?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make the names much longer, for no benefit in most cases. I don't want to have to write, e.g., currency.euro. euro should be enough.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure though in most cases you would have the currency symbol you use most on your keyboard anyways, so the long name isn't too terrible as you wouldn't use it too much. But yeah it's not ideal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure though in most cases you would have the currency symbol you use most on your keyboard anyways, so the long name isn't too terrible as you wouldn't use it too much. But yeah it's not ideal.

I think that many of these symbols aren't on keyboard layouts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make the names much longer, for no benefit in most cases. I don't want to have to write, e.g., currency.euro. euro should be enough.

It would be even worse than that, since you most likely would want the text font. So #sym.currency.euro

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also by putting it under colon, they'll be able to use auto completion to avoid having to write out the whole modifier

.double ∷
.tri ⁝
.tri.op ⫶
Expand Down Expand Up @@ -574,17 +575,39 @@ smile ⌣
frown ⌢

// Currency.
afghani ؋
baht ฿
bitcoin ₿
cedi ₵
cent ¢
dollar $
dong ₫
dorome ߾
dram ֏
euro €
@deprecated: `franc` is deprecated, unadopted symbol for currency no longer in use
franc ₣
guarani ₲
hryvnia ₴
kip ₭
lari ₾
lira ₺
manat ₼
naira ₦
peso ₱
pound £
riel ៛
ruble ₽
rupee ₹
rupee
.indian ₹
.general ₨
.tamil ௹
.wancho 𞋿
shekel ₪
taka ৳
taman ߿
tenge ₸
tugrik ₮
won ₩
yen ¥

Expand Down