Add remaining currency symbols, deprecate franc #59
Conversation
Add all relevant rupee symbols. I used "taka" for the bangladeshi rupee sign, since that is the name of the currency. "rupee.indian" is placed at the top of the list to avoid breaking changes. It's also the most widely used.
As far as I can gather, these are all extant symbols in unicode for currencies that are actively in use. Exceptions: - The "colon", used in costa rica - The gujarati rupee sign, as it has been proposed deprecated
|
I purposely avoided adding symbol names for currencies no longer in active use. |
|
Thoughts on also adding U+00A4 ¤ CURRENCY SIGN as |
I did consider that, but it seems to be a legacy symbol. Is it actually used? |
| colon : | ||
| .currency ₡ |
There was a problem hiding this comment.
This confused me a bit at first and I'm not sure this is a good name for the symbol, but I understand why you've done it.
An idea: maybe we could put all the currency symbols as modifiers under currency?
There was a problem hiding this comment.
That would make the names much longer, for no benefit in most cases. I don't want to have to write, e.g., currency.euro. euro should be enough.
There was a problem hiding this comment.
I figure though in most cases you would have the currency symbol you use most on your keyboard anyways, so the long name isn't too terrible as you wouldn't use it too much. But yeah it's not ideal.
There was a problem hiding this comment.
I figure though in most cases you would have the currency symbol you use most on your keyboard anyways, so the long name isn't too terrible as you wouldn't use it too much. But yeah it's not ideal.
I think that many of these symbols aren't on keyboard layouts
There was a problem hiding this comment.
That would make the names much longer, for no benefit in most cases. I don't want to have to write, e.g.,
currency.euro.euroshould be enough.
It would be even worse than that, since you most likely would want the text font. So #sym.currency.euro
There was a problem hiding this comment.
Also by putting it under colon, they'll be able to use auto completion to avoid having to write out the whole modifier
|
What about putting currencies under a module so that you can import what you need? |
I don't think there are any plans to have more categories than general symbols and emojis. In any case I think that would be a discussion not really specific to this PR? Edit: Also see the discussion under @mkorje 's comment |
Adds the following currency symbols:
Armenian Dram Sign - dram (Currency of Armenia)
Afghani Sign - afghani (Currency of Aghanistan)
Bengali Rupee Sign - taka (Currency of Bangladesh)
Tamil Rupee Sign - rupee.tamil (Alternative symbol for Indian rupee in the Tamil alphabet)
Thai Currency Symbol Baht - baht (Currency of Thailand)
Khmer Currency Symbol Riel - riel (Currency of Cambodia)
Colon Sign - colon.currency (Currency of Costa Rica)
Naira Sign - naira (Currency of Nigeria)
Rupee sign - rupee.general (Currency of Mauritius, Nepal, Pakistan, Seychelles, Sri Lanka)
New Sheqel Sign - shekel (Currency of Israel)
Dong Sign - dong (Currency of Vietnam)
Kip Sign - kip (Currency of Laos)
Tugrik sign - tugrik (Currency of Mongolia)
Guarani Sign - guarani (Currency of Paraguay)
Hryvnia Sign - hryvnia (Currency of Ukraine)
Tenge Sign - tenge (Currency of Kazakhstan)
Manat Sign - manat (Currency of Azerbaijan)
Lari Sign - lari (Currency of Georgia)
Wancho Ngun Sign - rupee.wancho (Alternative symbol for Indian rupee in the Wancho alphabet)
Nko Dorome Sign - dorome (Currency symbol in the N'ko alphabet)
Nko Taman Sign - taman (Currency symbol in the N'ko alphabet)
Deprecates the following symbol:
French Franc Sign - franc (Not only is the currency no longer in use, the symbol was only a proposal and never used)