chore: preview changes from openapi-generator v7 #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR previews changes that would be introduced in twilio-go when upgrading from openapi-generator v6 to v7. The changes primarily involve the removal of empty comment lines preceding function definitions across the codebase.
- Removes empty comment lines (
//) that appear immediately before function definitions - Updates constant naming conventions in hosted number order enum types
- Reorders some entries in documentation files
Reviewed Changes
Copilot reviewed 164 out of 166 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Multiple Go files across various Twilio API modules | Removes empty comment lines before function definitions |
rest/numbers/v3/model_hosted_number_order_enum_verification_type.go |
Updates constant names from CALL/BILL to PHONE_CALL/PHONE_BILL |
rest/numbers/v3/docs/HostedNumberOrderEnumVerificationType.md |
Updates documentation to reflect new constant names |
rest/taskrouter/v1/README.md and rest/api/v2010/README.md |
Minor reordering of documentation entries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tiwarishubham635
added a commit
to twilio/twilio-oai-generator
that referenced
this pull request
Oct 28, 2025
…on upgrade (#685) <!-- We appreciate the effort for this pull request but before that please make sure you read the contribution guidelines, then fill out the blanks below. Please format the PR title appropriately based on the type of change: <type>[!]: <description> Where <type> is one of: docs, chore, feat, fix, test, misc. Add a '!' after the type for breaking changes (e.g. feat!: new breaking feature). **All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.** Please enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged! e.g. Fixes #1 Closes #2 --> # Fixes # 1. In C#, for operations having json payload, there used to be a `vendorExtension`, `x-is-json` which used to be set to `true`. That is removed in MVR. Now, we are using `bodyParams` are present or not to detect if the payload is json. This is in coherence with all other helpers as well Preview PR - twilio/twilio-csharp#805 2. In Go, certain docs files are getting updated, Preview PR - twilio/twilio-go#303 ### Checklist - [x] I acknowledge that all my contributions will be made under the project's license - [ ] Run `make test-docker` - [ ] Verify affected language: - [ ] Generate [twilio-go](https://github.com/twilio/twilio-go) from our [OpenAPI specification](https://github.com/twilio/twilio-oai) using the [build_twilio_go.py](./examples/build_twilio_go.py) using `python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go` and inspect the diff - [ ] Run `make test` in `twilio-go` - [ ] Create a pull request in `twilio-go` - [ ] Provide a link below to the pull request - [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) - [ ] I have read the [Contribution Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md) and my PR follows them - [ ] I have titled the PR appropriately - [ ] I have updated my branch with the main branch - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added the necessary documentation about the functionality in the appropriate .md file - [ ] I have added inline documentation to the code I modified If you have questions, please create a GitHub Issue in this repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Preview PR to show what changes are introduced in twilio-go when using v7 of openapi-generator
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.