chore: changes in different languages for openapi-generator-cli version upgrade #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbansla
reviewed
Sep 29, 2025
| ///<summary> The test_number_float </summary> | ||
| [JsonProperty("test_number_float")] | ||
| public float? TestNumberFloat { get; private set; } | ||
| public float TestNumberFloat { get; private set; } |
Contributor
There was a problem hiding this comment.
Is this TestNumberFloat mandatory ?
sbansla
reviewed
Sep 29, 2025
| int? testInteger = null, | ||
| DateTime? testDate = null, | ||
| float? testNumberFloat = null, | ||
| float testNumberFloat = null, |
Contributor
There was a problem hiding this comment.
It seems like, testNumberFloat is mandatory since ? is removed.
But at the same time, we are keeping its default value as null.
Contributor
Author
There was a problem hiding this comment.
the parameter here is non-nullable
Contributor
Author
There was a problem hiding this comment.
I have checked this case and added this commit to handle it correctly.
sbansla
approved these changes
Oct 28, 2025
tiwarishubham635
merged commit 8dc540b
into
twilio-java-generation-modernisation
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
vendorExtension,x-is-jsonwhich used to be set totrue. That is removed in MVR. Now, we are usingbodyParamsare present or not to detect if the payload is json. This is in coherence with all other helpers as wellPreview PR - chore: preview changes from openapi-generator v7 twilio-csharp#805
Checklist
make test-dockerpython examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-goand inspect the diffmake testintwilio-gotwilio-goIf you have questions, please create a GitHub Issue in this repository.