Add upgrade 0.35 command module #9175
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import { InjectRepository } from '@nestjs/typeorm'; | ||
|
|
||
| import { Command } from 'nest-commander'; | ||
| import { Repository } from 'typeorm'; | ||
|
|
||
| import { ActiveWorkspacesCommandRunner } from 'src/database/commands/active-workspaces.command'; | ||
| import { BaseCommandOptions } from 'src/database/commands/base.command'; | ||
| import { PhoneCallingCodeCreateColumnCommand } from 'src/database/commands/upgrade-version/0-35/0-35-phone-calling-code-create-column.command'; | ||
| import { RecordPositionBackfillCommand } from 'src/database/commands/upgrade-version/0-35/0-35-record-position-backfill.command'; | ||
| import { ViewGroupNoValueBackfillCommand } from 'src/database/commands/upgrade-version/0-35/0-35-view-group-no-value-backfill.command'; | ||
| import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity'; | ||
| import { SyncWorkspaceMetadataCommand } from 'src/engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command'; | ||
|
|
||
| @Command({ | ||
| name: 'upgrade-0.35', | ||
| description: 'Upgrade to 0.35', | ||
| }) | ||
| export class UpgradeTo0_35Command extends ActiveWorkspacesCommandRunner { | ||
| constructor( | ||
| @InjectRepository(Workspace, 'core') | ||
| protected readonly workspaceRepository: Repository<Workspace>, | ||
| private readonly viewGroupNoValueBackfillCommand: ViewGroupNoValueBackfillCommand, | ||
| private readonly syncWorkspaceMetadataCommand: SyncWorkspaceMetadataCommand, | ||
| private readonly phoneCallingCodeCreateColumnCommand: PhoneCallingCodeCreateColumnCommand, | ||
| private readonly recordPositionBackfillCommand: RecordPositionBackfillCommand, | ||
| ) { | ||
| super(workspaceRepository); | ||
| } | ||
|
|
||
| async executeActiveWorkspacesCommand( | ||
| passedParam: string[], | ||
| options: BaseCommandOptions, | ||
| workspaceIds: string[], | ||
| ): Promise<void> { | ||
| this.logger.log( | ||
| 'Running command to upgrade to 0.40: must start with phone calling code otherwise SyncMetadata will fail', | ||
| ); | ||
|
|
||
| await this.recordPositionBackfillCommand.executeActiveWorkspacesCommand( | ||
|
There was a problem hiding this comment. style: No error handling around sequential commands. If one fails, database could be left in inconsistent state. Consider wrapping in try/catch with rollback capability. |
||
| passedParam, | ||
| options, | ||
| workspaceIds, | ||
| ); | ||
|
|
||
| await this.phoneCallingCodeCreateColumnCommand.executeActiveWorkspacesCommand( | ||
| passedParam, | ||
| options, | ||
| workspaceIds, | ||
| ); | ||
|
|
||
| await this.viewGroupNoValueBackfillCommand.executeActiveWorkspacesCommand( | ||
| passedParam, | ||
| options, | ||
| workspaceIds, | ||
| ); | ||
|
|
||
| await this.syncWorkspaceMetadataCommand.executeActiveWorkspacesCommand( | ||
| passedParam, | ||
| { | ||
| ...options, | ||
| force: true, | ||
| }, | ||
| workspaceIds, | ||
| ); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { Module } from '@nestjs/common'; | ||
| import { TypeOrmModule } from '@nestjs/typeorm'; | ||
|
|
||
| import { PhoneCallingCodeCreateColumnCommand } from 'src/database/commands/upgrade-version/0-35/0-35-phone-calling-code-create-column.command'; | ||
| import { RecordPositionBackfillCommand } from 'src/database/commands/upgrade-version/0-35/0-35-record-position-backfill.command'; | ||
| import { UpgradeTo0_35Command } from 'src/database/commands/upgrade-version/0-35/0-35-upgrade-version.command'; | ||
| import { ViewGroupNoValueBackfillCommand } from 'src/database/commands/upgrade-version/0-35/0-35-view-group-no-value-backfill.command'; | ||
| import { RecordPositionBackfillModule } from 'src/engine/api/graphql/workspace-query-runner/services/record-position-backfill-module'; | ||
| import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity'; | ||
| import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity'; | ||
| import { FieldMetadataModule } from 'src/engine/metadata-modules/field-metadata/field-metadata.module'; | ||
| import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity'; | ||
| import { SearchModule } from 'src/engine/metadata-modules/search/search.module'; | ||
| import { WorkspaceMetadataVersionModule } from 'src/engine/metadata-modules/workspace-metadata-version/workspace-metadata-version.module'; | ||
| import { WorkspaceMigrationFactory } from 'src/engine/metadata-modules/workspace-migration/workspace-migration.factory'; | ||
| import { WorkspaceMigrationModule } from 'src/engine/metadata-modules/workspace-migration/workspace-migration.module'; | ||
| import { WorkspaceMigrationRunnerModule } from 'src/engine/workspace-manager/workspace-migration-runner/workspace-migration-runner.module'; | ||
| import { WorkspaceSyncMetadataCommandsModule } from 'src/engine/workspace-manager/workspace-sync-metadata/commands/workspace-sync-metadata-commands.module'; | ||
|
|
||
| @Module({ | ||
| imports: [ | ||
| TypeOrmModule.forFeature([Workspace], 'core'), | ||
| TypeOrmModule.forFeature( | ||
| [ObjectMetadataEntity, FieldMetadataEntity], | ||
| 'metadata', | ||
| ), | ||
| TypeOrmModule.forFeature([FieldMetadataEntity], 'metadata'), | ||
|
There was a problem hiding this comment. logic: FieldMetadataEntity is imported twice in TypeOrmModule.forFeature(). Remove the duplicate import on line 27. |
||
| WorkspaceSyncMetadataCommandsModule, | ||
| SearchModule, | ||
| WorkspaceMigrationRunnerModule, | ||
| WorkspaceMetadataVersionModule, | ||
| WorkspaceMigrationModule, | ||
| RecordPositionBackfillModule, | ||
| FieldMetadataModule, | ||
| ], | ||
| providers: [ | ||
| UpgradeTo0_35Command, | ||
| PhoneCallingCodeCreateColumnCommand, | ||
| WorkspaceMigrationFactory, | ||
| RecordPositionBackfillCommand, | ||
| ViewGroupNoValueBackfillCommand, | ||
| ], | ||
| }) | ||
| export class UpgradeTo0_35CommandModule {} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Log message incorrectly references version 0.40 instead of 0.35