Add upgrade 0.35 command module #9175
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reorganizes database upgrade commands by moving several data structure modifications from version 0.40 to 0.35, creating a clearer separation between schema changes and data migration.
- Critical bug: Incorrect version number in logging message in
0-35-upgrade-version.command.tsreferences version 0.40 instead of 0.35 - Redundant TypeOrmModule registration for FieldMetadataEntity in
0-40-upgrade-version.module.ts - Missing error handling in sequential command execution in
0-35-upgrade-version.command.tscould leave database in inconsistent state - Clearer upgrade path: schema changes in 0.35 (columns, positions) followed by data migration in 0.40
8 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| this.logger.log( | ||
| 'Running command to upgrade to 0.40: must start with phone calling code otherwise SyncMetadata will fail', | ||
| ); |
There was a problem hiding this comment.
syntax: Log message incorrectly references version 0.40 instead of 0.35
| this.logger.log( | |
| 'Running command to upgrade to 0.40: must start with phone calling code otherwise SyncMetadata will fail', | |
| ); | |
| this.logger.log( | |
| 'Running command to upgrade to 0.35: must start with phone calling code otherwise SyncMetadata will fail', | |
| ); |
| 'Running command to upgrade to 0.40: must start with phone calling code otherwise SyncMetadata will fail', | ||
| ); | ||
|
|
||
| await this.recordPositionBackfillCommand.executeActiveWorkspacesCommand( |
There was a problem hiding this comment.
style: No error handling around sequential commands. If one fails, database could be left in inconsistent state. Consider wrapping in try/catch with rollback capability.
| [ObjectMetadataEntity, FieldMetadataEntity], | ||
| 'metadata', | ||
| ), | ||
| TypeOrmModule.forFeature([FieldMetadataEntity], 'metadata'), |
There was a problem hiding this comment.
logic: FieldMetadataEntity is imported twice in TypeOrmModule.forFeature(). Remove the duplicate import on line 27.
| await this.phoneCallingCodeMigrateDataCommand.executeActiveWorkspacesCommand( | ||
| passedParam, | ||
| options, |
There was a problem hiding this comment.
logic: log message still references 0.40 but some commands were moved to 0.35
Moving commands from 0.40 to 0.35 since they should be ready for 0.35.