-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop node-sass
support
#41112
base: main
Are you sure you want to change the base?
Drop node-sass
support
#41112
Conversation
898c14a
to
1816145
Compare
1816145
to
f232df5
Compare
@@ -46,7 +46,7 @@ | |||
} | |||
} | |||
@include color-mode(dark, true) { | |||
--custom-color: #{mix($indigo, $blue, 50%)}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the mix($indigo, $blue, 50%)
because color.mix($indigo, $blue, 50%)
doesn't return a value as an hex string, but a color that should be transformed to a hex string. I don't think it's necessary to add such complexity for now. Let's see at the end of the PR if we reintroduce something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the mix($indigo, $blue, 50%) is not appropriate in this as css and bootstrap has feature of colour-mix which include the change or mix in colour using hex string but you can't use colour.mix to change colour into hex string
@@ -75,7 +75,7 @@ | |||
"js-test-jquery": "cross-env JQUERY=true npm run js-test-karma", | |||
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel js-lint css-lint lockfile-lint", | |||
"docs": "npm-run-all docs-build docs-lint", | |||
"docs-build": "hugo --cleanDestinationDir --printUnusedTemplates", | |||
"docs-build": "PATH=$(npm config get prefix)/bin:$PATH hugo --cleanDestinationDir --printUnusedTemplates", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change the path because, otherwise, hugo
(via the npm command) will use the sass binary installed from our package.json
that doesn't support sass --embedded
-> sass --embedded is unavailable in pure JS mode.
.
Following https://gohugo.io/functions/resources/tocss/#dart-sass, I've installed on my computer sass
that supports sass --embedded
so the script must use this version instead of the one in node_modules/.bin
.
This temp solution makes it work when running npm run docs
and npm run start
locally on macOS after having installed globally sass
with brew install sass/sass/sass
.
If there's no other solution, we might need to modify the contributing guidelines to add this extra step and link to https://gohugo.io/functions/resources/tocss/#installing-in-a-development-environment
906f9b8
to
8ec183e
Compare
Warning
This PR is heavily draft. It prepares the modifications for when we'll drop
node-sass
supportDescription
This PR drops
node-sass
support.Thanks to this drop, we can also make modifications to remove the deprecation warning from the recent Dart Sass versions.
Sub-tasks
node-sass
GitHub workflowRGBA
withrgba
sass
→ 1.79.xDeprecation Warning: blue() is deprecated. Suggestion: color.channel($color, "blue", $space: rgb) More info: https://sass-lang.com/d/color-functions
(same thing forred()
andgreen()
) → 1816145sass
→ 1.80.xsass
→ 1.81.xsass
→ 1.82.xsass
→ 1.83.xCheck the diff between
dist/css/bootstrap.css
from the main branch and this oneCheck if we need to do something about
rfs
repository (andvendor
dir here)Hugo documentation build
See also TESTING Docs: switch to dart sass #39700
Check the documentation to remove
node-sass
specific content (if any)Add somewhere in the documentation that Bootstrap doesn't support
node-sass
anymoreAfter the merge of this PR, update the examples repository
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #40962
Closes #40849