-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale Jobs-runner resources separately from main_backend #186
Closed
Closed
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0ee7b8a
add jobsrunner resources and change deployment_jobs.yaml to accept re…
kcheng16 393fc8f
jobsrunner.resources comment didnt make it to github- edit comment
kcheng16 0481e6b
added change to values.yaml file on base of directory
kcheng16 e9c034d
update comment
kcheng16 4a83f42
removed extra spaces
kcheng16 3444397
fix linting issue: mid version & matching values.yaml
kcheng16 3e8e7dd
fix linting issue with comment wording
kcheng16 c457c9d
changing version
kcheng16 c3b88df
PR review - change nit wording
kcheng16 a258875
include separation of wf-backend resources from main-backend
kcheng16 7293146
edit spacing
kcheng16 395b7a6
add wf backend resource values
kcheng16 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ apiVersion: v2 | |
name: retool | ||
description: A Helm chart for Kubernetes | ||
type: application | ||
version: 6.2.9 | ||
version: 6.3.0 | ||
maintainers: | ||
- name: Retool Engineering | ||
email: [email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -231,7 +231,7 @@ extraVolumeMounts: [] | |
|
||
extraVolumes: [] | ||
|
||
# These resource specifications apply to the main backend and workflows backend pods. | ||
# These resource specifications will apply to the main backend, jobs-runner, db-connector, and workflows backend pods(unless if container specific resources are set) | ||
resources: | ||
# If you have more than 1 replica, the minimum recommended resources configuration is as follows: | ||
# - cpu: 2048m | ||
|
@@ -299,6 +299,15 @@ jobRunner: | |
# will already launch a job runner pod | ||
# enabled: true | ||
|
||
# These resource apply only to the jobs-runner pod. Set the resources to scale jobs-runner pod separately from main-backend pods. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit reword: If necessary, specify the resources to provision the jobRunner pod separately from the main backend pods. |
||
# resources: | ||
# limits: | ||
# cpu: 4096m | ||
# memory: 8192Mi | ||
# requests: | ||
# cpu: 2048m | ||
# memory: 4096Mi | ||
|
||
# Annotations for job runner pods | ||
annotations: {} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, reword:
These resource specifications will apply to the main backend, jobs-runner, dbconnector, and workflows-backend pods unless container specific resources are set.