Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Jobs-runner resources separately from main_backend #186

Closed
wants to merge 12 commits into from
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.2.9
version: 6.3.0
maintainers:
- name: Retool Engineering
email: [email protected]
Expand Down
4 changes: 4 additions & 0 deletions charts/retool/templates/deployment_jobs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,11 @@ spec:
{{- end }}
{{- end }}
resources:
{{- if .Values.jobRunner.resources }}
{{ toYaml .Values.jobRunner.resources | indent 10 }}
{{- else }}
{{ toYaml .Values.resources | indent 10 }}
{{- end }}
{{- if regexMatch "^([0-9]+)\\.([0-9]+)\\.([0-9]+)" .Values.image.tag }}
{{- if semverCompare ">=2.110.0-0" .Values.image.tag }}
livenessProbe:
Expand Down
11 changes: 10 additions & 1 deletion charts/retool/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ extraVolumeMounts: []

extraVolumes: []

# These resource specifications apply to the main backend and workflows backend pods.
# These resource specifications will apply to the main backend, jobs-runner, db-connector, and workflows backend pods(unless if container specific resources are set)
Copy link
Contributor

@JatinNanda JatinNanda Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, reword:

These resource specifications will apply to the main backend, jobs-runner, dbconnector, and workflows-backend pods unless container specific resources are set.

resources:
# If you have more than 1 replica, the minimum recommended resources configuration is as follows:
# - cpu: 2048m
Expand Down Expand Up @@ -299,6 +299,15 @@ jobRunner:
# will already launch a job runner pod
# enabled: true

# These resource apply only to the jobs-runner pod. Set the resources to scale jobs-runner pod separately from main-backend pods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit reword:

If necessary, specify the resources to provision the jobRunner pod separately from the main backend pods.

# resources:
# limits:
# cpu: 4096m
# memory: 8192Mi
# requests:
# cpu: 2048m
# memory: 4096Mi

# Annotations for job runner pods
annotations: {}

Expand Down
11 changes: 10 additions & 1 deletion values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ extraVolumeMounts: []

extraVolumes: []

# These resource specifications apply to the main backend and workflows backend pods.
# These resource specifications will apply to the main backend, jobs-runner, db-connector, and workflows backend pods(unless if container specific resources are set)
resources:
# If you have more than 1 replica, the minimum recommended resources configuration is as follows:
# - cpu: 2048m
Expand Down Expand Up @@ -299,6 +299,15 @@ jobRunner:
# will already launch a job runner pod
# enabled: true

# These resource apply only to the jobs-runner pod. Set the resources to scale jobs-runner pod separately from main-backend pods.
# resources:
# limits:
# cpu: 4096m
# memory: 8192Mi
# requests:
# cpu: 2048m
# memory: 4096Mi

# Annotations for job runner pods
annotations: {}

Expand Down
Loading