Scale Jobs-runner resources separately from main_backend #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JatinNanda
reviewed
Sep 14, 2024
charts/retool/values.yaml
Outdated
| @@ -231,7 +231,7 @@ extraVolumeMounts: [] | |||
|
|
|||
| extraVolumes: [] | |||
|
|
|||
| # These resource specifications apply to the main backend and workflows backend pods. | |||
| # These resource specifications will apply to the main backend, jobs-runner, db-connector, and workflows backend pods(unless if container specific resources are set) | |||
There was a problem hiding this comment.
nit, reword:
These resource specifications will apply to the main backend, jobs-runner, dbconnector, and workflows-backend pods unless container specific resources are set.
JatinNanda
reviewed
Sep 14, 2024
charts/retool/values.yaml
Outdated
| @@ -299,6 +299,15 @@ jobRunner: | |||
| # will already launch a job runner pod | |||
| # enabled: true | |||
|
|
|||
| # These resource apply only to the jobs-runner pod. Set the resources to scale jobs-runner pod separately from main-backend pods. | |||
There was a problem hiding this comment.
nit reword:
If necessary, specify the resources to provision the jobRunner pod separately from the main backend pods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to set resource.request/limit for jobs-runner container. Separating it from same resources used in for main backend