fixed jirav1 detector email pattern #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmussani
reviewed
Dec 31, 2024
| @@ -16,7 +16,7 @@ var ( | |||
| invalidTokenPattern = "Z7VoI?J0K4rF#LBfkhO&LAWX" | |||
| validDomainPattern = "hereisavalidsubdomain.heresalongdomain.com" | |||
| invalidDomainPattern = "?y4r3fs1ewqec12v1e3tl.5Hcsrcehic89saXd.ro@" | |||
| validEmailPattern = "[email protected]" | |||
There was a problem hiding this comment.
@kashifkhan0771 Not sure but the old input is also valid email and should pass the user case.
There was a problem hiding this comment.
Our common email pattern is not configured to capture capital letters. I guess we need a small enhancement in the common email pattern. Including flag (?i) in start will work.
Thoughts @abmussani @zricethezav @ahrav ?
There was a problem hiding this comment.
Oh wow, I didn't realize the common email pattern regex was case sensitive. I think making it insensitive is the right approach. 👍
zricethezav
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the github issue #3818
Checklist:
make test-community)?make lintthis requires golangci-lint)?