JiraToken v1 detector is subtly broken

[rgmz]

The JiraToken v1 detector detector has a defect that prevents it from working in many cases.

If the email match contains any whitespace (e.g., email = [email protected]), the strings.Split can silently fail len != 2 (#2746)

trufflehog/pkg/detectors/jiratoken/v1/jiratoken.go

Lines 56 to 59 in def734a

	email = strings.Split(email[0], " ")
	if len(email) != 2 {
	continue
	}

Related

It seems to have been broken over a year ago by #1288 without anyone noticing, even after unit tests were supposedly added in #3614.

See also: #2746 (comment), #3773, #3817

[kashifkhan0771]

I believe a simple solution is that we can use our email regex pattern from common here. Somehow this detector was missed in the pull request