-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove normal_direction_ll
for nonconservative terms
#2062
base: main
Are you sure you want to change the base?
Remove normal_direction_ll
for nonconservative terms
#2062
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
As expected changing the normal directions caused slightly different results and with that some failing mhd tests. For validation I additionally ran convergence tests using
Looking at these results, I think it would be fine to introduce the averaged normal direction and update the test values. Another open problem is that the test |
Thanks for testing it out in Since the test is failing due to domain error (negative density or pressure) I think it's a real failure. My guess is that it's related to the boundary condition imposition Trixi.jl/src/solvers/dgmulti/dg.jl Lines 555 to 560 in aaf0166
since all the other MHD tests still pass. |
That makes sense. I just looked at the boundary conditions that are used in the elixir and noticed that I will try to replace this with
|
@patrickersing looks like your new |
normal_direction_ll
for nonconservative termsnormal_direction_ll
for nonconservative terms
Once this is ready to go we can schedule the next breaking release 0.9, cf. #1997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
et al. [`flux_nonconservative_powell`](@ref) for conforming meshes but it yields different | ||
results on non-conforming meshes(!). On curvilinear meshes this formulation applies the | ||
local normal direction compared to the averaged one used in [`flux_nonconservative_powell`](@ref). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also be true in 3D but the subcell limiting implementation is not done (yet) right @amrueda ? That is why a corresponding comment in the 3D ideal GLM-MHD file is not done?
This PR simplifies the nonconservative terms to only depend on a single averaged
normal_direction
, instead of bothnormal_direction_average
andnormal_direction_ll
(see #2049).This should also enable setting boundary conditions for nonconservative terms #1445