Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normal_direction_ll #58

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patrickersing
Copy link
Contributor

This PR removes normal_direction_ll from the function signature of the nonconservative terms, to account for the changes in trixi-framework/Trixi.jl#2062.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.50%. Comparing base (e5b40ad) to head (2430c7b).

Files with missing lines Patch % Lines
src/equations/shallow_water_wet_dry_2d.jl 0.00% 2 Missing ⚠️
src/equations/shallow_water_multilayer_2d.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e5b40ad) and HEAD (2430c7b). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (e5b40ad) HEAD (2430c7b)
5 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
- Coverage   99.27%   81.50%   -17.78%     
===========================================
  Files          61       61               
  Lines        2630     2563       -67     
===========================================
- Hits         2611     2089      -522     
- Misses         19      474      +455     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant