Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(suite): analytics OS versions #15789

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Feat(suite): analytics OS versions #15789

merged 2 commits into from
Dec 6, 2024

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Dec 5, 2024 •
edited
Loading

Description

  1. add a new ipcMain api getSystemInformation
  2. optionally use it to enrich context for Analytics 'suite-ready' event (desktop only)

Related Issue

Resolve #15770

@Lemonexe Lemonexe marked this pull request as ready for review December 5, 2024 14:53
@Lemonexe Lemonexe merged commit d7355c5 into develop Dec 6, 2024
25 checks passed
@Lemonexe Lemonexe deleted the feat/analytics-os-version branch December 6, 2024 10:06
This was referenced Dec 6, 2024
Merged
Merged
@bosomt
Copy link
Contributor

bosomt commented Dec 6, 2024

QA OK

osName=macos&osVersion=10.15.7&desktopOsVersion=24.1.0&desktopOsName=darwin&desktopOsArchitecture=arm64

Info:

  • Suite version: desktop 25.1.0 (5557f53)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.1.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 2625facf1fe9b71db120439853ceca0a61bb8396)
  • Transport: BridgeTransport 2.0.33

@bosomt
Copy link
Contributor

bosomt commented Dec 10, 2024

QA OK

osName=macos&osVersion=10.15.7&desktopOsVersion=24.1.0&desktopOsName=darwin&desktopOsArchitecture=arm64

Info:

  • Suite version: desktop 24.12.1 (0d4070d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.12.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 17f2a3256b2631823c2bad1855fab61b27985fd2)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-sanderson peter-sanderson peter-sanderson approved these changes

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Analytics: New desktop OS tracking
3 participants
@Lemonexe @bosomt @peter-sanderson