Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(suite-desktop): downgrade electron #15766

Merged
merged 1 commit into from
Dec 6, 2024
Merged

chore(suite-desktop): downgrade electron #15766

merged 1 commit into from
Dec 6, 2024

Conversation

Lemonexe
Copy link
Contributor

@Lemonexe Lemonexe commented Dec 4, 2024 •
edited
Loading

Description

Downgrade electron from 33 to 32.

It shall be kept at 32 until we are ready to cut off macOS Catalina.

ℹ️ https://github.com/electron/electron/blob/main/README.md#platform-support
ℹ️ https://trezor.io/learn/a/os-requirements-for-trezor

@Lemonexe Lemonexe force-pushed the chore/downgrade-electron branch from b395b7d to ffb751e Compare December 4, 2024 12:21
@Lemonexe Lemonexe marked this pull request as ready for review December 4, 2024 12:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 17
  • More info

Learn more about 𝝠 Expo Github Action

@komret
Copy link
Contributor

komret commented Dec 4, 2024

Let's not merge this yet, final decision TBD.

@Lemonexe Lemonexe force-pushed the chore/downgrade-electron branch from ffb751e to a8af3f8 Compare December 6, 2024 10:19
@Lemonexe
Copy link
Contributor Author

Lemonexe commented Dec 6, 2024 •
edited
Loading

As discussed on standup, I'll merge this, following implementation of OS analytics in #15789

@Lemonexe Lemonexe merged commit 3bc342a into develop Dec 6, 2024
70 checks passed
@Lemonexe Lemonexe deleted the chore/downgrade-electron branch December 6, 2024 10:47
@bosomt
Copy link
Contributor

bosomt commented Dec 6, 2024

QA OK

browserName=electron&browserVersion=32.2.6

Info:

  • Suite version: desktop 25.1.0 (5557f53)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.1.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 2625facf1fe9b71db120439853ceca0a61bb8396)
  • Transport: BridgeTransport 2.0.33

@bosomt
Copy link
Contributor

bosomt commented Dec 10, 2024

QA OK

electron&browserVersion=32.2.6

Info:

  • Suite version: desktop 24.12.1 (0d4070d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.12.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 17f2a3256b2631823c2bad1855fab61b27985fd2)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komret komret komret approved these changes

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@martykan martykan Awaiting requested review from martykan martykan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lemonexe @komret @bosomt