Transport device disconnected

packages/connect/src/core/index.ts

@@ -714,8 +714,13 @@ const onCallDevice = async (
         const response = messageResponse;
 
         if (response) {
-            await device.cleanup();
+            const shouldReleaseSession =
+                response.success ||
+                (!response.success &&
+                    // @ts-expect-error
+                    response?.payload?.error !== 'device disconnected during action');
 
+            await device.cleanup(shouldReleaseSession);
             if (useCoreInPopup) {
                 // We need to send response before closing popup
                 sendCoreMessage(response);

packages/connect/src/device/Device.ts

@@ -327,13 +327,15 @@ export class Device extends TypedEmitter<DeviceEvents> {
         this.keepTransportSession = false;
     }
 
-    async cleanup() {
+    async cleanup(release = true) {
         // remove all listeners
         this.eventNames().forEach(e => this.removeAllListeners(e as keyof DeviceEvents));
 
         // make sure that Device_CallInProgress will not be thrown
         delete this.runPromise;
-        await this.release();
+        if (release) {
+            await this.release();
+        }
     }
 
     // call only once, right after device creation

packages/suite/src/components/suite/ConnectDevicePrompt.tsx

@@ -74,8 +74,10 @@ const getMessageId = ({
             return isDesktop() ? 'TR_NO_TRANSPORT_DESKTOP' : 'TR_NO_TRANSPORT';
         case 'device-bootloader':
             return 'TR_DEVICE_CONNECTED_BOOTLOADER';
-        case 'device-unacquired':
+        case 'device-used-elsewhere':
             return 'TR_DEVICE_CONNECTED_UNACQUIRED';
+        case 'device-unacquired':
+            return 'TR_NEEDS_ATTENTION_UNABLE_TO_CONNECT';
         default: {
             if (connected) {
                 return !showWarning ? 'TR_DEVICE_CONNECTED' : 'TR_DEVICE_CONNECTED_WRONG_STATE';

packages/suite/src/components/suite/PrerequisitesGuide/DeviceAcquire.tsx

@@ -2,14 +2,16 @@ import { MouseEventHandler } from 'react';
 
 import { acquireDevice } from '@suite-common/wallet-core';
 import { Button } from '@trezor/components';
-import { isDesktop } from '@trezor/env-utils';
 
 import { Translation, TroubleshootingTips } from 'src/components/suite';
 import { useDevice, useDispatch } from 'src/hooks/suite';
-import { TROUBLESHOOTING_TIP_RECONNECT } from 'src/components/suite/troubleshooting/tips';
+import {
+    TROUBLESHOOTING_TIP_RECONNECT,
+    TROUBLESHOOTING_TIP_CLOSE_ALL_TABS,
+} from 'src/components/suite/troubleshooting/tips';
 
 export const DeviceAcquire = () => {
-    const { isLocked, device } = useDevice();
+    const { isLocked } = useDevice();
     const dispatch = useDispatch();
 
     const isDeviceLocked = isLocked();
@@ -21,45 +23,15 @@ export const DeviceAcquire = () => {
 
     const ctaButton = (
         <Button data-testid="@device-acquire" isLoading={isDeviceLocked} onClick={handleClick}>
-            <Translation id="TR_ACQUIRE_DEVICE" />
+            <Translation id="TR_TRY_AGAIN" />
         </Button>
     );
 
-    const tips = [
-        {
-            key: 'device-used-elsewhere',
-            heading: <Translation id="TR_DEVICE_CONNECTED_UNACQUIRED" />,
-            description: device?.transportSessionOwner ? (
-                <Translation
-                    id="TR_DEVICE_CONNECTED_UNACQUIRED_DESCRIPTION"
-                    values={{
-                        transportSessionOwner: device.transportSessionOwner,
-                    }}
-                />
-            ) : (
-                // legacy bridge does not share transportSessionOwner information
-                <Translation id="TR_DEVICE_CONNECTED_UNACQUIRED_DESCRIPTION_UNKNOWN_APP" />
-            ),
-        },
-        {
-            key: 'device-acquire',
-            heading: <Translation id="TR_TROUBLESHOOTING_CLOSE_TABS" />,
-            description: (
-                <Translation
-                    id={
-                        isDesktop()
-                            ? 'TR_TROUBLESHOOTING_CLOSE_TABS_DESCRIPTION_DESKTOP'
-                            : 'TR_TROUBLESHOOTING_CLOSE_TABS_DESCRIPTION'
-                    }
-                />
-            ),
-        },
-        TROUBLESHOOTING_TIP_RECONNECT,
-    ];
+    const tips = [TROUBLESHOOTING_TIP_CLOSE_ALL_TABS, TROUBLESHOOTING_TIP_RECONNECT];
 
     return (
         <TroubleshootingTips
-            label={<Translation id="TR_ACQUIRE_DEVICE_TITLE" />}
+            label={<Translation id="TR_NEEDS_ATTENTION_UNABLE_TO_CONNECT" />}
             cta={ctaButton}
             items={tips}
         />

packages/suite/src/components/suite/PrerequisitesGuide/DeviceUnreadable.tsx

@@ -13,6 +13,7 @@ import {
     TROUBLESHOOTING_TIP_UNREADABLE_HID,
     TROUBLESHOOTING_TIP_SUITE_DESKTOP_TOGGLE_BRIDGE,
     TROUBLESHOOTING_TIP_RECONNECT,
+    TROUBLESHOOTING_TIP_CLOSE_ALL_TABS,
 } from 'src/components/suite/troubleshooting/tips';
 import { useSelector, useDispatch } from 'src/hooks/suite';
 import type { TrezorDevice } from 'src/types/suite';
@@ -143,6 +144,11 @@ export const DeviceUnreadable = ({ device }: DeviceUnreadableProps) => {
         // you might have a very old device which is no longer supported current bridge
         // if on desktop - try toggling between the 2 bridges we have available
         items.push(TROUBLESHOOTING_TIP_SUITE_DESKTOP_TOGGLE_BRIDGE);
+    } else {
+        // it might also be unreadable because device was acquired on transport layer by another app and never released.
+        // this should be rather exceptional case that happens only when sessions synchronization is broken or other app
+        // is not cooperating with us
+        items.push(TROUBLESHOOTING_TIP_CLOSE_ALL_TABS);
     }
 
     return (

packages/suite/src/components/suite/PrerequisitesGuide/DeviceUsedElsewhere.tsx

@@ -0,0 +1,58 @@
+import { MouseEventHandler } from 'react';
+
+import { acquireDevice } from '@suite-common/wallet-core';
+import { Button } from '@trezor/components';
+
+import { Translation, TroubleshootingTips } from 'src/components/suite';
+import { useDevice, useDispatch } from 'src/hooks/suite';
+import {
+    TROUBLESHOOTING_TIP_RECONNECT,
+    TROUBLESHOOTING_TIP_CLOSE_ALL_TABS,
+} from 'src/components/suite/troubleshooting/tips';
+
+export const DeviceUsedElsewhere = () => {
+    const { isLocked, device } = useDevice();
+    const dispatch = useDispatch();
+
+    const isDeviceLocked = isLocked();
+
+    const handleClick: MouseEventHandler = e => {
+        e.stopPropagation();
+        dispatch(acquireDevice());
+    };
+
+    const ctaButton = (
+        <Button
+            data-testid="@device-used-elsewhere"
+            isLoading={isDeviceLocked}
+            onClick={handleClick}
+        >
+            <Translation id="TR_ACQUIRE_DEVICE" />
+        </Button>
+    );
+
+    const tips = [
+        {
+            key: 'device-used-elsewhere',
+            heading: <Translation id="TR_DEVICE_CONNECTED_UNACQUIRED" />,
+            description: (
+                <Translation
+                    id="TR_DEVICE_CONNECTED_UNACQUIRED_DESCRIPTION"
+                    values={{
+                        transportSessionOwner: device?.transportSessionOwner || 'unknown',
+                    }}
+                />
+            ),
+        },
+        TROUBLESHOOTING_TIP_CLOSE_ALL_TABS,
+        TROUBLESHOOTING_TIP_RECONNECT,
+    ];
+
+    return (
+        <TroubleshootingTips
+            label={<Translation id="TR_ACQUIRE_DEVICE_TITLE" />}
+            cta={ctaButton}
+            items={tips}
+        />
+    );
+};

packages/suite/src/components/suite/PrerequisitesGuide/PrerequisitesGuide.tsx

@@ -26,6 +26,7 @@ import { DeviceNoFirmware } from './DeviceNoFirmware';
 import { DeviceUpdateRequired } from './DeviceUpdateRequired';
 import { DeviceDisconnectRequired } from './DeviceDisconnectRequired';
 import { MultiShareBackupInProgress } from './MultiShareBackupInProgress';
+import { DeviceUsedElsewhere } from './DeviceUsedElsewhere';
 
 const Wrapper = styled.div`
     display: flex;
@@ -68,6 +69,8 @@ export const PrerequisitesGuide = ({ allowSwitchDevice }: PrerequisitesGuideProp
                     return <DeviceConnect isWebUsbTransport={isWebUsbTransport} />;
                 case 'device-unacquired':
                     return <DeviceAcquire />;
+                case 'device-used-elsewhere':
+                    return <DeviceUsedElsewhere />;
                 case 'device-unreadable':
                     return <DeviceUnreadable device={device} />;
                 case 'device-unknown':

packages/suite/src/components/suite/troubleshooting/tips/index.tsx

@@ -99,3 +99,17 @@ export const TROUBLESHOOTING_TIP_RECONNECT = {
         />
     ),
 };
+
+export const TROUBLESHOOTING_TIP_CLOSE_ALL_TABS = {
+    key: 'device-acquire',
+    heading: <Translation id="TR_TROUBLESHOOTING_CLOSE_TABS" />,
+    description: (
+        <Translation
+            id={
+                isDesktop()
+                    ? 'TR_TROUBLESHOOTING_CLOSE_TABS_DESCRIPTION_DESKTOP'
+                    : 'TR_TROUBLESHOOTING_CLOSE_TABS_DESCRIPTION'
+            }
+        />
+    ),
+};

packages/suite/src/support/messages.ts

@@ -2087,6 +2087,10 @@ const messages = defineMessagesWithTypeCheck({
         defaultMessage: 'Trezor is not readable.',
         id: 'TR_NEEDS_ATTENTION_UNREADABLE',
     },
+    TR_NEEDS_ATTENTION_UNABLE_TO_CONNECT: {
+        defaultMessage: 'Failed to communicate with Trezor',
+        id: 'TR_NEEDS_ATTENTION_UNABLE_TO_CONNECT',
+    },
     TR_UDEV_DOWNLOAD_TITLE: {
         defaultMessage: 'Download udev rules',
         id: 'TR_UDEV_DOWNLOAD_TITLE',
@@ -6790,11 +6794,6 @@ const messages = defineMessagesWithTypeCheck({
         defaultMessage:
             'The app {transportSessionOwner} may currently be using this device. You can take control of the device if needed.',
     },
-    TR_DEVICE_CONNECTED_UNACQUIRED_DESCRIPTION_UNKNOWN_APP: {
-        id: 'TR_DEVICE_CONNECTED_UNACQUIRED_DESCRIPTION_UNKNOWN_APP',
-        defaultMessage:
-            'Another app may currently be using this device. You can take control of the device if needed.',
-    },
     TR_WIPE_OR_UPDATE: {
         id: 'TR_WIPE_OR_UPDATE',
         defaultMessage: 'Reset device or update firmware',

packages/suite/src/utils/suite/prerequisites.ts

@@ -28,6 +28,9 @@ export const getPrerequisiteName = ({ router, device, transport }: GetPrerequisi
         return 'device-disconnect-required';
     }
 
+    if (device.type === 'unacquired' && device?.transportSessionOwner)
+        return 'device-used-elsewhere';
+
     // device features cannot be read, device is probably used in another window
     if (device.type === 'unacquired') return 'device-unacquired';
 

packages/transport/src/api/usb.ts

@@ -27,11 +27,6 @@ interface TransportInterfaceDevice {
     device: USBDevice;
 }
 
-/**
- * Local error. We cast it to "device disconnected during action" from bridge as it means the same
- */
-const INTERFACE_DEVICE_DISCONNECTED = 'The device was disconnected.' as const;
-
 export class UsbApi extends AbstractApi {
     chunkSize = 64;
 
@@ -218,11 +213,8 @@ export class UsbApi extends AbstractApi {
             return this.success(Buffer.from(res.data.buffer));
         } catch (err) {
             this.logger?.error(`usb: device.transferIn error ${err}`);
-            if (err.message === INTERFACE_DEVICE_DISCONNECTED) {
-                return this.error({ error: ERRORS.DEVICE_DISCONNECTED_DURING_ACTION });
-            }
 
-            return this.error({ error: ERRORS.INTERFACE_DATA_TRANSFER, message: err.message });
+            return this.handleReadWriteError(err);
         }
     }
 
@@ -255,12 +247,7 @@ export class UsbApi extends AbstractApi {
 
             return this.success(undefined);
         } catch (err) {
-            this.logger?.error(`usb: device.transferOut error ${err}`);
-            if (err.message === INTERFACE_DEVICE_DISCONNECTED) {
-                return this.error({ error: ERRORS.DEVICE_DISCONNECTED_DURING_ACTION });
-            }
-
-            return this.error({ error: ERRORS.INTERFACE_DATA_TRANSFER, message: err.message });
+            return this.handleReadWriteError(err);
         }
     }
 
@@ -517,6 +504,29 @@ export class UsbApi extends AbstractApi {
         return [hidDevices, nonHidDevices];
     }
 
+    // https://github.com/trezor/trezord-go/blob/db03d99230f5b609a354e3586f1dfc0ad6da16f7/usb/libusb.go#L545
+    private handleReadWriteError(err: Error) {
+        if (
+            [
+                // node usb
+                'LIBUSB_TRANSFER_ERROR',
+                'LIBUSB_ERROR_PIPE',
+                'LIBUSB_ERROR_IO',
+                'LIBUSB_ERROR_NO_DEVICE',
+                'LIBUSB_ERROR_OTHER',
+                // web usb
+                ERRORS.INTERFACE_DATA_TRANSFER,
+                'The device was disconnected.',
+            ].some(disconnectedErr => {
+                return err.message.includes(disconnectedErr);
+            })
+        ) {
+            return this.error({ error: ERRORS.DEVICE_DISCONNECTED_DURING_ACTION });
+        }
+
+        return this.unknownError(err);
+    }
+
     public dispose() {
         if (this.usbInterface) {
             this.usbInterface.onconnect = null;

packages/transport/tests/apiUsb.test.ts

@@ -58,7 +58,7 @@ describe('api/usb', () => {
 
         const result = await promise;
         if (result.success) throw new Error('Unexpected success');
-        expect(result.error).toContain('A transfer error has occurred.');
+        expect(result.error).toContain('unexpected error');
         expect(reset).toHaveBeenCalledTimes(1);
     });