-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport device disconnected #15615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
transport-device-disconnected
branch
2 times, most recently
from
November 28, 2024 15:21
0f0f58d
to
ddade07
Compare
🚀 Expo preview is ready!
|
Merged
mroz22
force-pushed
the
transport-device-disconnected
branch
2 times, most recently
from
December 2, 2024 15:22
e024cd8
to
63e4b15
Compare
…e same as with trezord-go
…rate from device-unacquired
mroz22
force-pushed
the
transport-device-disconnected
branch
from
December 2, 2024 17:23
63e4b15
to
4709f3b
Compare
mroz22
requested review from
MiroslavProchazka,
szymonlesisz,
martykan and
marekrjpolak
as code owners
December 2, 2024 17:23
…component rendering
mroz22
commented
Dec 3, 2024
@@ -28,6 +28,9 @@ export const getPrerequisiteName = ({ router, device, transport }: GetPrerequisi | |||
return 'device-disconnect-required'; | |||
} | |||
|
|||
if (device.type === 'unacquired' && device?.transportSessionOwner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: device.used ?
marekrjpolak
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device.transportSessionOwner
.device.used = true
? This way this screen never renders for the legacy bridge since it never returnstransportSessionOwner
.todo: maybe we should enumerate in this case to be sure that it really disconnected
?related issues: