Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile device management - check device authenticity #14617

Closed
Nodonisko opened this issue Sep 30, 2024 · 2 comments · Fixed by #15331
Closed

Mobile device management - check device authenticity #14617

Nodonisko opened this issue Sep 30, 2024 · 2 comments · Fixed by #15331
Assignees
Labels
changelog User facing features that are potentionally worth mentioning in changelog mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker

Comments

@Nodonisko
Copy link
Contributor

Nodonisko commented Sep 30, 2024

Figma

Check device authenticity (=DAC)

  • User can trigger DAC from device settings
  • Authenticity check is available only for TS family devices (TS3, TS5)
  • When user clicks on Check device authenticity he is informed about the purpose of DAC
  • When he continues he is prompted to continue and confirm on Trezor Device
  • If the DAC is successful, user is informed that the device is genuine and he can continue using it
  • If the DAC is not successful, user is informed that device might be compromised and he should contact our customer service

Implementation notes:

  • POC in this PR POC: verify device authenticity on mobile #10247
  • Latest version of react-native-quick-crypto should support subtle crypto features we need to make this work, would be also nice to use this library to replace whole crypto-browserify because it's much faster (when I tried last time there was some issue with messaging system, but we should be able to make it work)
@Nodonisko Nodonisko added the mobile Suite Lite issues and PRs label Sep 30, 2024
@Nodonisko Nodonisko added this to the Mobile - Manage device #1 milestone Sep 30, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Sep 30, 2024
@yanascz yanascz self-assigned this Nov 4, 2024
@matejkriz matejkriz added the changelog User facing features that are potentionally worth mentioning in changelog label Nov 5, 2024
@yanascz yanascz moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Nov 11, 2024
@yanascz yanascz moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Nov 18, 2024
@STew790
Copy link
Contributor

STew790 commented Nov 29, 2024

QA NOK
If I cancel the DAC on host via "X" button, I return to dashboard.

Screenrecorder-2024-11-29-19-45-29-65.mp4

When I use my dev TS3 (with unlocked bootloader) it should fail the DAC (at least it does on destkop), but it doesn't and it just returns to device settings

1000014269.mp4

QA OK

  • I can trigger the DAC from device settings for both TS3/TS5 (I can cancel as well, apart from above mentioned issue)
  • I am informed about the DAC actually is
  • If the DAC is successful, I am informed I am safe to use the device

Info
24.11.3 38ae448

@STew790 STew790 moved this from 🤝 Needs QA to 🎯 To do in Suite Mobile Nov 29, 2024
@STew790 STew790 added the QA NOK Issue doesn't pass the QA and some changes are needed. label Nov 29, 2024
@yanascz yanascz moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Nov 30, 2024
@yanascz yanascz moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Dec 5, 2024
@STew790
Copy link
Contributor

STew790 commented Dec 6, 2024

QA OK
The issue mentioned was already tested here #15677 and it was fixed 🎉

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Dec 6, 2024
@STew790 STew790 added QA OK Issue passed QA without any blocker and removed QA NOK Issue doesn't pass the QA and some changes are needed. labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog User facing features that are potentionally worth mentioning in changelog mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

4 participants