Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): navigate back to device settings if DAC is cancelled #15659

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Nov 30, 2024

Tapping on the "X" close button in the app leads to calling navigation.goBack() (in GoBackIcon) and TrezorConnect.cancel() (in DeviceInteractionScreenWrapper) which aborts the TrezorConnect.authenticateDevice() call and navigation.goBack() is called incorrectly once more.

Related Issue

#14617

@yanascz yanascz requested a review from a team as a code owner November 30, 2024 18:51
Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 12
  • More info

Learn more about 𝝠 Expo Github Action

@yanascz yanascz merged commit 4c29bba into develop Dec 1, 2024
15 checks passed
@yanascz yanascz deleted the fix/native/dac-cancel-via-app branch December 1, 2024 16:11
Copy link

sentry-io bot commented Dec 9, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Popup closed _callSuper(index.android) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants