Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#108] Inject RetryWire.class into RtGithub #122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HlibYasieniev
Copy link

@HlibYasieniev HlibYasieniev commented May 29, 2024

@h1alexbel, please take a look.

PR-Codex Overview

This PR inject 'RetryWire' to 'RtGithub' client

Detailed Summary

  • Implementation: This change configures the RtGithub client to use RetryWire instead of the default AutoRedirectingWire. RetryWire is used to retry a few times before giving up and throwing an exception
  • Motivation: The default AutoRedirectingWire handles HTTP redirects but does not retry on transient failures, unlike RetryWire

Please review and provide feedback. Thank you!


PR-Codex overview

This PR focuses on enhancing GitHub API calls in GhIdentity.java by adding a retry mechanism for better reliability.

Detailed summary

  • Added import com.jcabi.http.wire.RetryWire; for retry mechanism
  • Modified GitHub instantiation to include .through(RetryWire.class) for improved API call reliability

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link
Contributor

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YasenevGleb thank you for this pull request. Looks good. However incoming pull requests still will be failed, due to bad credentials error, like in this case.
Let's make sure that simulation job in mvn.yml executes only in master branch. To keep on track that job is green, let's create and issue in case of job failure, take a look at this example, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants