Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulation tests are constantly failing #108

Open
h1alexbel opened this issue May 10, 2024 · 5 comments
Open

simulation tests are constantly failing #108

h1alexbel opened this issue May 10, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@h1alexbel
Copy link
Contributor

h1alexbel commented May 10, 2024

Our integration tests are flaky, mostly because of timing and delays from GitHub API. Let's fix them

@h1alexbel h1alexbel added the bug Something isn't working label May 10, 2024
@h1alexbel
Copy link
Contributor Author

13:20:38.639 [main] INFO com.jcabi.http.request.BaseRequest -- #fetch(GET api.github.com /rate_limit): [200 OK] in 158ms
13:20:38.640 [main] INFO git.tracehub.codereview.action.github.GhIdentity -- Connecting to GitHub...
13:20:38.640 [main] INFO git.tracehub.codereview.action.github.GhIdentity -- GitHub object instantiated
13:20:38.858 [main] INFO com.jcabi.http.request.BaseRequest -- #fetch(GET api.github.com /user): [200 OK] in 217ms
13:20:38.858 [main] INFO git.tracehub.codereview.action.github.GhIdentity -- GitHub connected as @tracehubgit
13:20:39.225 [main] INFO com.jcabi.http.request.BaseRequest -- #fetch(GET api.github.com /repos/h1alexbel/test/pulls/311/reviews/1971184892/comments): [200 OK] in 366ms
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.823 s - in it.JsonCommentsITCase
[INFO] 
[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    AnalysisRoutineITCase.analyzesCodeReview:69 » IndexOutOfBounds Index: 0, Size: 0

@HlibYasieniev
Copy link

@h1alexbel can I take this one?

@h1alexbel
Copy link
Contributor Author

@YasenevGleb sure, go ahead!

HlibYasieniev pushed a commit to HlibYasieniev/code-review-action that referenced this issue May 29, 2024
@HlibYasieniev
Copy link

@h1alexbel created a pull request, please take a look:)
#122

@h1alexbel
Copy link
Contributor Author

h1alexbel commented May 29, 2024

@YasenevGleb nice, reviewed. BTW, you can link issues you work on in the pull requests

HlibYasieniev pushed a commit to HlibYasieniev/code-review-action that referenced this issue May 30, 2024
HlibYasieniev added a commit to HlibYasieniev/code-review-action that referenced this issue May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants