Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix and mio-aio dev-dependencies to the latest #6552

Merged
merged 1 commit into from
May 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ members = [

[workspace.metadata.spellcheck]
config = "spellcheck.toml"

4 changes: 2 additions & 2 deletions tokio/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ signal-hook-registry = { version = "1.1.1", optional = true }

[target.'cfg(unix)'.dev-dependencies]
libc = { version = "0.2.149" }
nix = { version = "0.27.1", default-features = false, features = ["fs", "socket"] }
nix = { version = "0.29.0", default-features = false, features = ["aio", "fs", "socket"] }

[target.'cfg(windows)'.dependencies.windows-sys]
version = "0.48"
Expand Down Expand Up @@ -149,7 +149,7 @@ rand = "0.8.0"
wasm-bindgen-test = "0.3.0"

[target.'cfg(target_os = "freebsd")'.dev-dependencies]
mio-aio = { version = "0.8.0", features = ["tokio"] }
mio-aio = { version = "0.9.0", features = ["tokio"] }

[target.'cfg(loom)'.dev-dependencies]
loom = { version = "0.7", features = ["futures", "checkpoint"] }
Expand Down
31 changes: 9 additions & 22 deletions tokio/tests/io_async_fd.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#![warn(rust_2018_idioms)]
#![cfg(all(unix, feature = "full"))]

use std::os::unix::io::{AsRawFd, IntoRawFd, RawFd};
use std::os::unix::io::{AsRawFd, RawFd};
use std::sync::{
atomic::{AtomicBool, Ordering},
Arc,
Expand All @@ -13,7 +13,7 @@ use std::{
task::{Context, Waker},
};

use nix::unistd::{close, read, write};
use nix::unistd::{read, write};

use futures::poll;

Expand Down Expand Up @@ -58,18 +58,18 @@ impl TestWaker {

#[derive(Debug)]
struct FileDescriptor {
fd: RawFd,
fd: std::os::fd::OwnedFd,
}

impl AsRawFd for FileDescriptor {
fn as_raw_fd(&self) -> RawFd {
self.fd
self.fd.as_raw_fd()
}
}

impl Read for &FileDescriptor {
fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {
read(self.fd, buf).map_err(io::Error::from)
read(self.fd.as_raw_fd(), buf).map_err(io::Error::from)
}
}

Expand All @@ -81,7 +81,7 @@ impl Read for FileDescriptor {

impl Write for &FileDescriptor {
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
write(self.fd, buf).map_err(io::Error::from)
write(&self.fd, buf).map_err(io::Error::from)
}

fn flush(&mut self) -> io::Result<()> {
Expand All @@ -99,12 +99,6 @@ impl Write for FileDescriptor {
}
}

impl Drop for FileDescriptor {
fn drop(&mut self) {
let _ = close(self.fd);
}
}

fn set_nonblocking(fd: RawFd) {
use nix::fcntl::{OFlag, F_GETFL, F_SETFL};

Expand Down Expand Up @@ -133,17 +127,10 @@ fn socketpair() -> (FileDescriptor, FileDescriptor) {
SockFlag::empty(),
)
.expect("socketpair");
let fds = (
FileDescriptor {
fd: fd_a.into_raw_fd(),
},
FileDescriptor {
fd: fd_b.into_raw_fd(),
},
);
let fds = (FileDescriptor { fd: fd_a }, FileDescriptor { fd: fd_b });

set_nonblocking(fds.0.fd);
set_nonblocking(fds.1.fd);
set_nonblocking(fds.0.fd.as_raw_fd());
set_nonblocking(fds.1.fd.as_raw_fd());

fds
}
Expand Down
13 changes: 7 additions & 6 deletions tokio/tests/io_poll_aio.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use mio_aio::{AioFsyncMode, SourceApi};
use std::{
future::Future,
io, mem,
os::fd::AsFd,
os::unix::io::{AsRawFd, RawFd},
pin::{pin, Pin},
task::{Context, Poll},
Expand All @@ -17,9 +18,9 @@ mod aio {
use super::*;

#[derive(Debug)]
struct TokioSource(mio_aio::Source<nix::sys::aio::AioFsync>);
struct TokioSource<'fd>(mio_aio::Source<nix::sys::aio::AioFsync<'fd>>);

impl AioSource for TokioSource {
impl<'fd> AioSource for TokioSource<'fd> {
fn register(&mut self, kq: RawFd, token: usize) {
self.0.register_raw(kq, token)
}
Expand All @@ -29,9 +30,9 @@ mod aio {
}

/// A very crude implementation of an AIO-based future
struct FsyncFut(Aio<TokioSource>);
struct FsyncFut<'fd>(Aio<TokioSource<'fd>>);

impl FsyncFut {
impl<'fd> FsyncFut<'fd> {
pub fn submit(self: Pin<&mut Self>) -> io::Result<()> {
let p = unsafe { self.map_unchecked_mut(|s| &mut s.0 .0) };
match p.submit() {
Expand All @@ -41,7 +42,7 @@ mod aio {
}
}

impl Future for FsyncFut {
impl<'fd> Future for FsyncFut<'fd> {
type Output = io::Result<()>;

fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
Expand Down Expand Up @@ -134,7 +135,7 @@ mod aio {
#[tokio::test]
async fn fsync() {
let f = tempfile().unwrap();
let fd = f.as_raw_fd();
let fd = f.as_fd();
let mode = AioFsyncMode::O_SYNC;
let source = TokioSource(mio_aio::Fsync::fsync(fd, mode, 0));
let poll_aio = Aio::new_for_aio(source).unwrap();
Expand Down
4 changes: 1 addition & 3 deletions tokio/tests/net_unix_pipe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,10 @@ async fn anon_pipe_spawn_echo() -> std::io::Result<()> {
#[cfg(target_os = "linux")]
async fn anon_pipe_from_owned_fd() -> std::io::Result<()> {
use nix::fcntl::OFlag;
use std::os::unix::io::{FromRawFd, OwnedFd};

const DATA: &[u8] = b"this is some data to write to the pipe";

let fds = nix::unistd::pipe2(OFlag::O_CLOEXEC | OFlag::O_NONBLOCK)?;
let (rx_fd, tx_fd) = unsafe { (OwnedFd::from_raw_fd(fds.0), OwnedFd::from_raw_fd(fds.1)) };
let (rx_fd, tx_fd) = nix::unistd::pipe2(OFlag::O_CLOEXEC | OFlag::O_NONBLOCK)?;

let mut rx = pipe::Receiver::from_owned_fd(rx_fd)?;
let mut tx = pipe::Sender::from_owned_fd(tx_fd)?;
Expand Down
Loading