Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix and mio-aio dev-dependencies to the latest #6552

Merged
merged 1 commit into from
May 25, 2024

Conversation

asomers
Copy link
Contributor

@asomers asomers commented May 12, 2024

Motivation

Use the latest version of Nix as requested by @fkm3 .

Solution

Update Nix to the latest version. This version uses I/O Safety for most functions. It also necessitates updating the mio-aio dev dependency.

This PR supersedes #6474 , but it depends on unreleased nix and mio-aio crates.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io M-net Module: tokio/net labels May 12, 2024
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

tokio/tests/io_poll_aio.rs Outdated Show resolved Hide resolved
@fkm3
Copy link
Contributor

fkm3 commented May 13, 2024

Thanks!

nix 0.29.0 and mio-aio 0.9.0 use I/O Safety.
@asomers asomers marked this pull request as ready for review May 24, 2024 23:57
@asomers asomers requested a review from Darksonn May 24, 2024 23:57
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 12920ce into tokio-rs:master May 25, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io M-net Module: tokio/net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants