Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular contracts - rename extensions to modules #3969

Merged
merged 1 commit into from
Aug 14, 2024

Modular contracts - rename extensions to modules (#3969)

4ce99be
Select commit
Loading
Failed to load commit list.
Merged

Modular contracts - rename extensions to modules #3969

Modular contracts - rename extensions to modules (#3969)
4ce99be
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 14, 2024 in 0s

59.17% (-0.01%) compared to 03a809a, passed because coverage increased by -0.01% when compared to adjusted base (59.18%)

View this Pull Request on Codecov

59.17% (-0.01%) compared to 03a809a, passed because coverage increased by -0.01% when compared to adjusted base (59.18%)

Details

Codecov Report

Attention: Patch coverage is 62.24490% with 37 lines in your changes missing coverage. Please review.

Project coverage is 59.17%. Comparing base (03a809a) to head (4ce99be).

Files Patch % Lines
...odular/ModularCore/write/uninstallModuleByProxy.ts 66.66% 19 Missing ⚠️
...ular/ModularCore/write/uninstallPublishedModule.ts 55.55% 8 Missing ⚠️
...odular/ModularCore/write/installPublishedModule.ts 58.82% 7 Missing ⚠️
...kages/thirdweb/src/contract/actions/resolve-abi.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3969      +/-   ##
==========================================
- Coverage   59.18%   59.17%   -0.01%     
==========================================
  Files         957      957              
  Lines       76391    76386       -5     
  Branches     3469     3467       -2     
==========================================
- Hits        45211    45205       -6     
  Misses      30507    30507              
- Partials      673      674       +1     
Files Coverage Δ
...ackages/sdk/src/evm/constants/contract-features.ts 100.00% <ø> (ø)
...ackages/sdk/src/evm/constants/thirdweb-features.ts 100.00% <ø> (ø)
legacy_packages/sdk/src/evm/core/sdk.ts 66.32% <ø> (ø)
...cy_packages/sdk/src/evm/schema/contracts/custom.ts 96.87% <ø> (ø)
...kages/thirdweb/src/contract/actions/resolve-abi.ts 81.87% <50.00%> (ø)
...odular/ModularCore/write/installPublishedModule.ts 59.15% <58.82%> (ø)
...ular/ModularCore/write/uninstallPublishedModule.ts 57.35% <55.55%> (ø)
...odular/ModularCore/write/uninstallModuleByProxy.ts 66.66% <66.66%> (ø)

... and 3 files with indirect coverage changes