-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular contracts - rename extensions to modules #3969
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3969 +/- ##
==========================================
- Coverage 59.18% 59.17% -0.01%
==========================================
Files 957 957
Lines 76391 76386 -5
Branches 3469 3467 -2
==========================================
- Hits 45211 45205 -6
Misses 30507 30507
- Partials 673 674 +1
*This pull request uses carry forward flags. Click here to find out more.
|
@kumaryash90 could you do this rename on top of my branch please? I cleaned up the code Gen and removed a lot of unused abis |
@kumaryash90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trusting this is only name changes and has been tested thoroughly
Merge activity
|
<!-- start pr-codex --> ## PR-Codex overview This PR focuses on refactoring the codebase to replace `ModularExtension` with `ModularModule` and update related components and schemas. ### Detailed summary - Replaced `ModularExtension` with `ModularModule` in various files - Updated component names and paths accordingly - Updated schemas and JSON files related to `ModularModule` > The following files were skipped due to too many changes: `apps/dashboard/src/components/contract-components/contract-publish-form/factory-fieldset.tsx`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/events/ExtensionInstalled.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/events/ExtensionUninstalled.ts`, `apps/dashboard/src/components/contract-components/contract-publish-form/modular-contract-fieldset.tsx`, `packages/thirdweb/src/contract/actions/resolve-abi.ts`, `apps/dashboard/src/contract-ui/tabs/manage/components/getModuleInstalledParams.ts`, `packages/thirdweb/src/extensions/modular/ModularCore/write/uninstallModuleByProxy.ts`, `packages/thirdweb/scripts/generate/abis/modular/IModularCore.json`, `apps/dashboard/src/components/contract-components/contract-publish-form/index.tsx`, `legacy_packages/sdk/src/evm/common/any-evm-utils/getModularDeploymentInfo.ts`, `legacy_packages/sdk/src/evm/core/sdk.ts`, `apps/dashboard/src/components/contract-components/contract-publish-form/default-factory.tsx`, `apps/dashboard/src/contract-ui/tabs/manage/components/install-extension-params.tsx`, `packages/thirdweb/src/extensions/modular/ModularCore/write/uninstallPublishedExtension.ts`, `apps/dashboard/src/components/contract-components/contract-publish-form/module-input.tsx`, `packages/thirdweb/src/extensions/modular/ModularCore/write/installPublishedExtension.ts`, `packages/thirdweb/src/exports/extensions/modular.ts`, `packages/thirdweb/src/extensions/modular/__generated__/MintableERC20/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/RoyaltyERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/MintableERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/RoyaltyERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ClaimableERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/MintableERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/SimpleMetadataERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/SimpleMetadataERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/OpenEditionMetadataERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/OpenEditionMetadataERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/DelayedRevealBatchMetadataERC721/read/getModuleConfig.ts`, `legacy_packages/sdk/test/evm/modular-publish-deploy.test.ts`, `packages/thirdweb/scripts/generate/abis/modular/SimpleMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/SimpleMetadataERC1155.json`, `packages/thirdweb/scripts/generate/abis/modular/ModularCore.json`, `apps/dashboard/src/contract-ui/tabs/manage/page.tsx`, `packages/thirdweb/src/extensions/modular/__generated__/ModularExtension/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularExtension/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ClaimableERC20/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ClaimableERC1155/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/BatchMetadataERC721/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/BatchMetadataERC1155/read/getExtensionConfig.ts`, `legacy_packages/sdk/test/evm/mock/mockModuleWithInterface.ts`, `legacy_packages/sdk/src/evm/common/modular/compatibleExtensions.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularCore/read/getInstalledExtensions.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/read/getInstalledExtensions.ts`, `apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx`, `apps/dashboard/src/contract-ui/tabs/manage/components/InstalledExtensionsTable.tsx`, `legacy_packages/sdk/src/evm/constants/thirdweb-features.ts`, `packages/thirdweb/scripts/generate/abis/modular/OpenEditionMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/OpenEditionMetadataERC1155.json`, `packages/thirdweb/src/extensions/prebuilts/deploy-modular-core.test.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/write/installExtension.ts`, `packages/thirdweb/scripts/generate/abis/modular/BatchMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/BatchMetadataERC1155.json`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/write/uninstallExtension.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularCore/write/installExtension.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularCore/write/uninstallExtension.ts`, `apps/dashboard/src/components/contract-components/contract-deploy-form/modular-contract-default-extensions-fieldset.tsx`, `packages/thirdweb/scripts/generate/abis/modular/RoyaltyERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/RoyaltyERC1155.json`, `packages/thirdweb/scripts/generate/abis/modular/DelayedRevealBatchMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/MintableERC1155.json`, `apps/dashboard/src/contract-ui/tabs/manage/components/ExtensionForm.tsx`, `packages/thirdweb/scripts/generate/abis/modular/MintableERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/ClaimableERC20.json`, `packages/thirdweb/scripts/generate/abis/modular/ClaimableERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/ClaimableERC1155.json`, `packages/thirdweb/scripts/generate/abis/modular/MintableERC20.json`, `legacy_packages/sdk/test/evm/mock/mockExtensionWithFunctionsMetadata.ts`, `legacy_packages/sdk/test/evm/mock/mockCoreMetadata.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
44d2852
to
6056554
Compare
6056554
to
4cda898
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @kumaryash90 and the rest of your teammates on Graphite |
<!-- start pr-codex --> ## PR-Codex overview The focus of this PR is to refactor the codebase to replace `ModularExtension` with `ModularModule` and update related components and schemas. ### Detailed summary - Replaced `ModularExtension` with `ModularModule` in various files - Updated component names and paths accordingly - Updated schemas and JSON files related to `ModularModule` - Removed unused files and imports > The following files were skipped due to too many changes: `apps/dashboard/src/components/contract-components/contract-publish-form/factory-fieldset.tsx`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/events/ExtensionInstalled.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/events/ExtensionUninstalled.ts`, `apps/dashboard/src/components/contract-components/contract-publish-form/modular-contract-fieldset.tsx`, `packages/thirdweb/src/contract/actions/resolve-abi.ts`, `apps/dashboard/src/contract-ui/tabs/manage/components/getModuleInstalledParams.ts`, `packages/thirdweb/src/extensions/modular/ModularCore/write/uninstallModuleByProxy.ts`, `packages/thirdweb/scripts/generate/abis/modular/IModularCore.json`, `apps/dashboard/src/components/contract-components/contract-publish-form/index.tsx`, `legacy_packages/sdk/src/evm/common/any-evm-utils/getModularDeploymentInfo.ts`, `legacy_packages/sdk/src/evm/core/sdk.ts`, `apps/dashboard/src/components/contract-components/contract-publish-form/default-factory.tsx`, `apps/dashboard/src/contract-ui/tabs/manage/components/install-extension-params.tsx`, `packages/thirdweb/src/extensions/modular/ModularCore/write/uninstallPublishedExtension.ts`, `apps/dashboard/src/components/contract-components/contract-publish-form/module-input.tsx`, `packages/thirdweb/src/extensions/modular/ModularCore/write/installPublishedExtension.ts`, `packages/thirdweb/src/exports/extensions/modular.ts`, `packages/thirdweb/src/extensions/modular/__generated__/MintableERC20/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/RoyaltyERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/MintableERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/RoyaltyERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ClaimableERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/MintableERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/SimpleMetadataERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/SimpleMetadataERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/OpenEditionMetadataERC721/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/OpenEditionMetadataERC1155/read/getModuleConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/DelayedRevealBatchMetadataERC721/read/getModuleConfig.ts`, `legacy_packages/sdk/test/evm/modular-publish-deploy.test.ts`, `packages/thirdweb/scripts/generate/abis/modular/SimpleMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/SimpleMetadataERC1155.json`, `packages/thirdweb/scripts/generate/abis/modular/ModularCore.json`, `apps/dashboard/src/contract-ui/tabs/manage/page.tsx`, `packages/thirdweb/src/extensions/modular/__generated__/ModularExtension/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularExtension/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ClaimableERC20/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ClaimableERC1155/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/BatchMetadataERC721/read/getExtensionConfig.ts`, `packages/thirdweb/src/extensions/modular/__generated__/BatchMetadataERC1155/read/getExtensionConfig.ts`, `legacy_packages/sdk/test/evm/mock/mockModuleWithInterface.ts`, `legacy_packages/sdk/src/evm/common/modular/compatibleExtensions.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularCore/read/getInstalledExtensions.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/read/getInstalledExtensions.ts`, `apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx`, `apps/dashboard/src/contract-ui/tabs/manage/components/InstalledExtensionsTable.tsx`, `legacy_packages/sdk/src/evm/constants/thirdweb-features.ts`, `packages/thirdweb/scripts/generate/abis/modular/OpenEditionMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/OpenEditionMetadataERC1155.json`, `packages/thirdweb/src/extensions/prebuilts/deploy-modular-core.test.ts`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/write/installExtension.ts`, `packages/thirdweb/scripts/generate/abis/modular/BatchMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/BatchMetadataERC1155.json`, `packages/thirdweb/src/extensions/modular/__generated__/ModularCore/write/uninstallExtension.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularCore/write/installExtension.ts`, `packages/thirdweb/src/extensions/modular/__generated__/IModularCore/write/uninstallExtension.ts`, `apps/dashboard/src/components/contract-components/contract-deploy-form/modular-contract-default-extensions-fieldset.tsx`, `packages/thirdweb/scripts/generate/abis/modular/RoyaltyERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/RoyaltyERC1155.json`, `packages/thirdweb/scripts/generate/abis/modular/DelayedRevealBatchMetadataERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/MintableERC1155.json`, `apps/dashboard/src/contract-ui/tabs/manage/components/ExtensionForm.tsx`, `packages/thirdweb/scripts/generate/abis/modular/MintableERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/ClaimableERC20.json`, `packages/thirdweb/scripts/generate/abis/modular/ClaimableERC721.json`, `packages/thirdweb/scripts/generate/abis/modular/ClaimableERC1155.json`, `packages/thirdweb/scripts/generate/abis/modular/MintableERC20.json`, `legacy_packages/sdk/test/evm/mock/mockExtensionWithFunctionsMetadata.ts`, `legacy_packages/sdk/test/evm/mock/mockCoreMetadata.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
4cda898
to
4ce99be
Compare
PR-Codex overview
This PR updates the codebase to replace
ModularExtension
withModularModule
and introduces new module-related configurations.Detailed summary
ModularExtension
withModularModule