Skip to content

fixup! ASoC: SOF: Add support for on-demand DSP boot #5457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ujfalusi merged 1 commit into from
Jun 18, 2025
Merged

fixup! ASoC: SOF: Add support for on-demand DSP boot #5457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sound/soc/sof/ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,19 @@ void sof_ipc4_mic_privacy_state_change(struct snd_sof_dev *sdev, bool state)
struct sof_ipc4_msg msg;
u32 data = state;

/*
* The mic privacy change notification's role is to notify the running
* firmware that there is a change in mic privacy state from whatever
* the state was before - since the firmware booted up or since the
* previous change during runtime.
*
* If the firmware has not been booted up, there is no need to send
* change notification (the firmware is not booted up).
* The firmware checks the current state during its boot.
*/
if (sdev->fw_state != SOF_FW_BOOT_COMPLETE)
return;

Copy link
Copy Markdown
Collaborator

@bardliao bardliao Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will firmware check the privacy state when it boots up?

Copy link
Copy Markdown
Collaborator Author

@ujfalusi ujfalusi Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it does

Copy link
Copy Markdown
Collaborator Author

@ujfalusi ujfalusi Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and if the firmware is not booted up then it does not need to be notified of a change (as it is not booted up)

Copy link
Copy Markdown
Collaborator

@bardliao bardliao Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and if the firmware is not booted up then it does not need to be notified of a change (as it is not booted up)

Right, I was just wondering do we need to boot up the firmware when the privacy state is changed. Apparently no, thanks.

msg.primary = SOF_IPC4_MSG_TARGET(SOF_IPC4_MODULE_MSG);
msg.primary |= SOF_IPC4_MSG_DIR(SOF_IPC4_MSG_REQUEST);
msg.primary |= SOF_IPC4_MOD_ID(SOF_IPC4_MOD_INIT_BASEFW_MOD_ID);
Expand Down
Loading