fixup! ASoC: SOF: Add support for on-demand DSP boot#5457
Conversation
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
| */ | ||
| if (sdev->fw_state != SOF_FW_BOOT_COMPLETE) | ||
| return 0; | ||
|
|
There was a problem hiding this comment.
Will firmware check the privacy state when it boots up?
There was a problem hiding this comment.
and if the firmware is not booted up then it does not need to be notified of a change (as it is not booted up)
There was a problem hiding this comment.
and if the firmware is not booted up then it does not need to be notified of a change (as it is not booted up)
Right, I was just wondering do we need to boot up the firmware when the privacy state is changed. Apparently no, thanks.
ujfalusi
force-pushed
the
peter/sof/pr/on-demand-privacy-01
branch
from
6316a9b to
a50c7b1
Compare
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Code change is good, but the inline comment needs to be clarified.
sound/soc/sof/ipc4.c
Outdated
| * If the firmware has not been booted up, there is no need to send | ||
| * change notification. The firmware only needs to be aware of a change, | ||
| * when it boots up the privacy state is checked by the firmware, it | ||
| * only needs to be notified if it has changed |
There was a problem hiding this comment.
Compiler error on grammar. "The firmware only needs.... , when it boots up....., it only needs to be notitied." Is the main point the notification does not need to be sent, if the firmware is not booted up?
There was a problem hiding this comment.
when the firmware is not booted it does not care about change, it is not booted, let me try to reword this.
ujfalusi
force-pushed
the
peter/sof/pr/on-demand-privacy-01
branch
from
a50c7b1 to
6878af6
Compare
|
Changes since v1:
|
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
I can understand the explanation now.
sound/soc/sof/ipc4.c
Outdated
| * | ||
| * If the firmware has not been booted up, there is no need to send | ||
| * change notification (the firmware is not booted up). | ||
| * The firmware checks the current state during it's boot. |
There was a problem hiding this comment.
typo: s/it's boot/its boot/
Do not send notification about privacy change if the fw is not booted up. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
force-pushed
the
peter/sof/pr/on-demand-privacy-01
branch
from
6878af6 to
1dc068a
Compare
|
Changes since v2:
|
4 participants
Do not send notification about privacy change if the fw is not booted up.