-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply qualname_overrides in more circumstances #191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 456 465 +9
=========================================
+ Hits 456 465 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this update should be documented https://icb-scanpydoc.readthedocs-hosted.com/en/latest/scanpydoc.elegant_typehints.html#module-scanpydoc.elegant_typehints ? Or no?
Also, just to be clear, this enables qualname_overrides
to interact with intersphinx mappings in a way that affects how the doc is fetched, and not just rendered? Is that right?
The docs already say “It defines a configuration value This PR just makes that work more reliably.
Sphinx fires the When intersphinx is enabled, it has an event handler for that event. If it fails, other event handlers for that event with a higher priority value are run (yeah higher priority value means lower priority). This PR adds a new event handler for |
Fixes doc problems in scverse/anndata#1726