Datatype Support in Quality Control and Impute #865
+153
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and improve readability
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
As discussed in #861, this refactors the quality control functions to use single dispatch for future datatype support.
To this end, the explicit_impute function has been reworked already. closes #848
Technical details
This pull request introduces significant changes to the
ehrapypreprocessing module, focusing on improving imputation and quality control functionalities. The main changes involve the addition of support fordaskarrays, the use ofsingledispatchfor function overloading, and the enhancement of test coverage for different array types.Possible enhancements
Please let's discuss the changes, as I am not yet fully happy with them.