medcat refreshed use draft

[eroell]

Accompanying notebook update to this PR.
Fixes theislab/ehrapy#591.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-12-12T12:37:40Z
----------------------------------------------------------------

Line #3.    from medcat.cat import CAT

Originally I thought of it as a dependency of ehrapy, but it's probably much better to keep them separated

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-12-12T12:37:41Z
----------------------------------------------------------------

Line #2.    cat = CAT.load_model_pack("./medcat_data/medmen_wstatus_2021_oct.zip")

Is it clear how people are getting it? I forgot whether there's a download function or something somewhere?

eroell commented on 2023-12-12T15:29:08Z
----------------------------------------------------------------

Yes, the 3rd cell downloads the data from the Web, into the directory ./medcata_data/ where the model is loaded from here

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

Zethson commented on 2023-12-12T12:37:42Z
----------------------------------------------------------------

I'd catch this Exception even if that's the whole idea. It just looks ugly and broken when rendered

[eroell]

Yes, the 3rd cell downloads the data from the Web, into the directory ./medcata_data/ where the model is loaded from here

---

View entire conversation on ReviewNB